Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: textarea value is being duplicated #62

Merged
merged 3 commits into from
Feb 24, 2023

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Feb 23, 2023

Fix bug introduced in #43 where we masked both textarea's value and textContent, which meant the text inside of the textarea would get duplicated. We can ignore textContent in this case and set it to an empty string.

@billyvg billyvg force-pushed the test-inputs-inserted-into-dom branch from c8d0066 to f7fec59 Compare February 23, 2023 01:34
@billyvg billyvg force-pushed the test-inputs-inserted-into-dom branch from f7fec59 to 8a487de Compare February 23, 2023 01:34
@billyvg billyvg changed the title test inputs inserted into dom fix: textarea value is being duplicated Feb 23, 2023
@billyvg billyvg marked this pull request as ready for review February 23, 2023 19:43
@billyvg billyvg requested review from mydea and Lms24 February 23, 2023 19:45
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@billyvg billyvg merged commit 00c5d28 into sentry-v1 Feb 24, 2023
@billyvg billyvg deleted the test-inputs-inserted-into-dom branch February 24, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants