fix(snapshot): Handle removed attributes #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`defaultMaskFn`
|
Let's merge this: #66 into this branch, then merge this and cut a release 🚀 |
This adds on top of #65 and adds a test for this, as well as streamlining this check in the `transformAttribute` method.
mydea
approved these changes
Feb 27, 2023
|
Let's maybe update the PR title to something like:
|
Lms24
changed the title
defaultMaskFn
|
Opened an upstream PR for this as well: rrweb-io#1157 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes getsentry/sentry-javascript#7278