Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure text masking for updated attributes works #83

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Mar 17, 2023

We had inconsistent casing for the tagName, leading to some masking slipping through.

@mydea mydea requested a review from billyvg March 17, 2023 10:22
@mydea mydea self-assigned this Mar 17, 2023
{
"id": 87,
"attributes": {
"value": "*** *****"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was unmasked before the change, triggered by el.setAttribute('value', 'new value').

@mydea mydea force-pushed the fn/attribute-masking-updates branch from 305e1f8 to c60b366 Compare March 17, 2023 12:34
We had inconsistent casing for the tagName, leading to some masking slipping through.
@mydea mydea force-pushed the fn/attribute-masking-updates branch from c60b366 to ed5c7a3 Compare March 17, 2023 12:41
@mydea mydea merged commit 950bd2c into sentry-v1 Mar 17, 2023
@mydea mydea deleted the fn/attribute-masking-updates branch March 17, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants