fix: Fix CSS rules captured in Safari #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Safari does not escape `:` in attribute selectors correctly, so we need to do that instead.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
billyvg
approved these changes
Apr 20, 2023
|
OK, so I tried this, and a problem is that |
|
Ah right, it might be that we need as well |
|
Is it possible this can fix the issue? If not I wonder if there's an alternative work around then so we can unblock folks |
billyvg
reviewed
Apr 27, 2023
| @@ -78,7 +91,7 @@ function isCSSImportRule(rule: CSSRule): rule is CSSImportRule { | |||
| function stringifyStyleSheet(sheet: CSSStyleSheet): string { | |||
| return sheet.cssRules | |||
| ? Array.from(sheet.cssRules) | |||
| .map((rule) => rule.cssText || '') | |||
| .map((rule) => rule.cssText ? validateStringifiedCssRule(rule.cssText) : '') | |||
There was a problem hiding this comment.
This should work now for inline css
There was a problem hiding this comment.
nice, could you verify this with an actual example app?
There was a problem hiding this comment.
@mydea Tested this out and it seems to work
There was a problem hiding this comment.
nice, feel free to merge then!
|
Thanks guys! |
mydea
pushed a commit
to getsentry/sentry-javascript
that referenced
this pull request
May 8, 2023
- fix: Fix some input masking (esp for radio buttons) (getsentry/rrweb#85) - fix: Unescaped `:` in CSS rule from Safari (getsentry/rrweb#86) - feat: Define custom elements (web components) (getsentry/rrweb#87)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari does not escape
:in attribute selectors correctly, so we need to do that instead.See rrweb-io#1208
ref getsentry/sentry-javascript#7703