Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import typing_extensions for compatibility with hosts on python <3.8 #3

Merged

Conversation

mwarkentin
Copy link
Member

What does this PR do?

Fixes state.apply from newer python/salt versions against older hosts running Python 3.7.

confirmed working from my mac to both deb10 (snuba-transactions-tiger) and deb11 (access-logs) targets

What issues does this PR fix or reference?

Fixes:

saltstack#59942
saltstack#62234

Previous Behavior

salt-ssh "snuba-transactions-tiger-1-1" state.apply base test=True

...

ModuleNotFoundError: No module named 'typing_extensions'

New Behavior

salt-ssh "snuba-transactions-tiger-1-1" state.apply base test=True

...

Summary for snuba-transactions-tiger-1-1
-------------
Succeeded: 65
Failed:     0
-------------
Total states run:     65
Total run time:    6.722 s

saltstack#59942
saltstack#62234

confirmed working from my mac to both deb10 (snuba-transactions-tiger) and deb11 (access-logs) targets
@joshuarli joshuarli merged commit 049ed1d into v3005-sentry-pypi Mar 15, 2023
@mwarkentin mwarkentin deleted the v3005-sentry-pypi-thin-typing-extensions branch March 15, 2023 19:48
@mwarkentin
Copy link
Member Author

mwarkentin commented Mar 15, 2023

@joshuarli published this to a release we can use:

pip install https://sentry-dev-infra-assets.storage.googleapis.com/salt-3005+0na.049ed1dd9a-py3-none-any.whl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants