Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(autofix) Fix rethinking missing initial prompt in plan+code #1371

Open
roaga opened this issue Nov 2, 2024 · 0 comments
Open

(autofix) Fix rethinking missing initial prompt in plan+code #1371

roaga opened this issue Nov 2, 2024 · 0 comments
Assignees
@roaga

Comments

@roaga
Copy link
Member

roaga commented Nov 2, 2024

the problem is that when there are no insights, we truncate the memory to the just the first item. But this is wrong if we have expanded files before the initial prompt.
@roaga roaga self-assigned this Nov 2, 2024
@roaga roaga mentioned this issue Nov 2, 2024
Merged
roaga added a commit that referenced this issue Nov 4, 2024
@roaga
fix(autofix): Fix rethink bug in plan+code due to pre-expanded files (#…
91352b3 
…1373)

The memory truncation logic upon a rethink always kept only 1 memory
item if you did it from before the first insight card. This broke
certain cases in the plan+code step since it can have multiple initial
messages. #1371

This PR fixes that by tracking how many items make up the "initial
prompt".

(also tacking on a small prompt tweak for insight sharing that seems to
help with #1372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roaga roaga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@roaga