Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(suggested-fix): key should be 'key', not 'token' #2146

Merged

Conversation

aldy505
Copy link
Collaborator

@aldy505 aldy505 commented May 16, 2023

I was upgrading my Sentry instance to the latest version, then I spent like 15 minutes wondering on why the Suggested Fix feature I made the PR of is gone. I thought the Sentry team changed the logic of that. It turns out I made a typo.

This is how I feel right now:

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@aldy505
Copy link
Collaborator Author

aldy505 commented May 16, 2023

It uses new design now (by default, see getsentry/sentry#47531). Here are a few screenshots:

image

image

image

Copy link
Member

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is why we should have tests 🙂 (not your fault, the repo is not in great shape to add more tests for new features).

Bump on that Playwright patch maybe @chadwhitacre @hubertdeng123 ?

@chadwhitacre
Copy link
Member

This is why we should have tests

Hrm ... I seem to recall some different approaches to test coverage over the years. 😜

@chadwhitacre chadwhitacre merged commit 1fa7734 into getsentry:master May 16, 2023
@aldy505 aldy505 deleted the fix/suggested-fix/key-definition branch May 16, 2023 23:11
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants