-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade ClickHouse to version 24.3.5.47.altinitystable #3399
base: master
Are you sure you want to change the base?
Conversation
git clone https://github.com/patsevanton/getsentry-self-hosted-fork.git
|
docker compose ps -a
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3399 +/- ##
=======================================
Coverage 99.01% 99.01%
=======================================
Files 3 3
Lines 203 203
=======================================
Hits 201 201
Misses 2 2 ☔ View full report in Codecov by Sentry. |
Historically we have been very careful when upgrading clickhouse in SaaS since it can introduce breaking changes. @getsentry/owners-snuba Is this safe to do? Last I heard prod was still on 23.8 |
how do I check compatibility with the new clickhouse? Maybe there are some tests? I have launched sentry with clickhouse 24.3 |
Description:
This pull request introduces an upgrade of the ClickHouse service to version
24.3.5.47.altinitystable
. The upgrade process includes updating the Docker image and enhancing the upgrade script to support the new version.Changes:
Docker Compose Update:
BASE_IMAGE
in thedocker-compose.yml
file toaltinity/clickhouse-server:24.3.5.47.altinitystable
.Upgrade Script Enhancement:
upgrade-clickhouse.sh
script to include the upgrade path from23.8
to24.3.5.47.altinitystable
.References:
Related Issues
Please review the changes and provide feedback. If everything looks good, feel free to merge this pull request.
Thank you!
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.