Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hermes bytecode bundle and source maps are not automatically uploaded on iOS #1569

Closed
Tracked by #2947
krystofwoldrich opened this issue Mar 28, 2023 · 2 comments · Fixed by #1667
Closed
Tracked by #2947

Comments

@krystofwoldrich
Copy link
Member

krystofwoldrich commented Mar 28, 2023

Description

Starting RN 0.71 react-native docs recommend using SOURCEMAP_FILE env to enable source maps on iOS.

sentry-cli doesn't recognize that Hermes source maps were generated (Warning: build produced no sourcemaps.) and doesn't upload any artifacts.

At the moment sentry-cli only recognizes source maps generated using the following flag EXTRA_PACKAGER_ARGS="--sourcemap-output $DERIVED_FILE_DIR/main.jsbundle.map", but this way doesn't enable Hesmes compiler source maps.

Context: Generating Hermes source map has a side effect. facebook/react-native#34043 (comment)

@krystofwoldrich
Copy link
Member Author

krystofwoldrich commented Apr 7, 2023

This should be moved to sentry-cli. Also, an issue to update the wizard to use SOURCEMAP_FILE should be created.

effort: medium, impact:medium

@krystofwoldrich krystofwoldrich transferred this issue from getsentry/sentry-react-native Apr 7, 2023
@github-actions
Copy link

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants