chore: update clap to v4 #1489
Merged
chore: update clap to v4 #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tbh I tried to do this one day and gave up, as I've seen no real value in moving to v4 😅 |
Well I've been too fed up with the trailing spaces in the help files constantly being removed when I change something (and my editor persistently removing it) so I tried updating... not exactly as easy as I've hoped for, but it's "done", at least... |
kamilogorek
approved these changes
Feb 22, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the migration guard from the changelog: https://github.com/clap-rs/clap/blob/master/CHANGELOG.md#400---2022-09-28
This was even more painful than the deprecations in v3.2
The biggest change was that all args with v4 now take a value by default, instead of being flags.