Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(debug-files): Use temp file handle instead of keeping zips in memory #1641

Merged
merged 1 commit into from
Jun 13, 2023
Merged

ref(debug-files): Use temp file handle instead of keeping zips in memory #1641

merged 1 commit into from
Jun 13, 2023

Conversation

kamilogorek
Copy link
Contributor

Closes #1622 (comment)

Profiled using https://crates.io/crates/cargo-instruments.

Before:
Screenshot 2023-06-13 at 16 00 07

After:
Screenshot 2023-06-13 at 16 00 19

@kamilogorek kamilogorek enabled auto-merge (squash) June 13, 2023 14:06
@kamilogorek kamilogorek merged commit c9d8d64 into master Jun 13, 2023
@kamilogorek kamilogorek deleted the optimize-debug-files branch June 13, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swatinem Swatinem Swatinem approved these changes

Assignees

@kamilogorek kamilogorek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate memory usage while uploading debug symbols
2 participants
@kamilogorek @Swatinem