ref(injection): Rebuild fixup_js_file on top of magic-string and sourcemap composition
#1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
changed the title
fixup_js_file on top of magic-stringfixup_js_file on top of magic-string and sourcemap composition
kamilogorek
reviewed
Aug 2, 2023
src/utils/sourcemaps/inject.rs
Outdated
| something else"#; | ||
|
|
||
| let m = PRE_INJECT_RE.find(source).unwrap(); | ||
| dbg!(&source[m.range()]); |
There was a problem hiding this comment.
Should we actually assert on something here?
There was a problem hiding this comment.
Forgot to remove that test when I was writing this. I don't think it serves much of a purpose.
kamilogorek
reviewed
Aug 2, 2023
kamilogorek
reviewed
Aug 2, 2023
Co-authored-by: Kamil Ogórek <[email protected]>
Co-authored-by: Kamil Ogórek <[email protected]>
kamilogorek
approved these changes
Aug 2, 2023
loewenheim
added a commit
that referenced
this pull request
Aug 3, 2023
loewenheim
added a commit
that referenced
this pull request
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes debug id injection into JS files precise.
"use strict";statement.magic-stringto insert the debug id code snippet at the injection point and append the//# debugIdcomment.magic-stringgive us a sourcemap that maps between the injected and original file. This is really only relevant for the code snippet, the comment is just appended and shouldn't affect mappings anyway.The sourcemap obtained in (3) is then used to rewrite the original sourcemap using
SourceMap::adjust_mappings.This also minorly refactors
fixup_js_file_end.