Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crons): Run monitors run program on check-in failure #2171

Merged
merged 1 commit into from
Sep 30, 2024

Commits on Sep 30, 2024

  1. fix(crons): Run program in monitors run even when sending check-in …

    …fails
    
    Fix a bug where a failure in sending the crons checkin before running the program in the `monitors run` command (e.g. due to a Sentry outage) would cause the program to be prevented from running. Now, we instead log the error and continue running the program.
    
    Also, ensure that a failure in sending the final checkin (after the program has finished) does not cause the program to exit with a different exit code. `sentry-cli monitors run` should propagate the exit code of the program it runs.
    
    Fixes #2169
    szokeasaurusrex committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    d6b4f3e View commit details
    Browse the repository at this point in the history