Merge a3c542c into 1bf8571

getsentry · May 10, 2023 · 13d5b25 · 13d5b25
2 parents 1bf8571 + a3c542c
commit 13d5b25
Show file tree

Hide file tree

Showing 9 changed files with 300 additions and 185 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -30,6 +30,7 @@ This change has no impact on grouping of the issues in Sentry.
 
 - Propagate span when copying scope (#2952)
 - Remove "/" from crash report file name (#3005)
+- Fix race condition in profiling serialization (#3018)
 
 ## 8.6.0
 

diff --git a/Sources/Sentry/SentryProfileTimeseries.mm b/Sources/Sentry/SentryProfileTimeseries.mm
@@ -7,8 +7,6 @@
 #    import "SentryLog.h"
 #    import "SentryTransaction.h"
 
-std::mutex _gSamplesArrayLock;
-
 /**
  * Print a debug log to help diagnose slicing errors.
  * @param start @c YES if this is an attempt to find the start of the sliced data based on the
@@ -44,51 +42,45 @@
 NSArray<SentrySample *> *_Nullable slicedProfileSamples(
     NSArray<SentrySample *> *samples, SentryTransaction *transaction)
 {
-    NSArray<SentrySample *> *samplesCopy;
-    {
-        std::lock_guard<std::mutex> l(_gSamplesArrayLock);
-        samplesCopy = [samples copy];
-    }
-
-    if (samplesCopy.count == 0) {
+    if (samples.count == 0) {
         return nil;
     }
 
     const auto transactionStart = transaction.startSystemTime;
     const auto firstIndex =
-        [samplesCopy indexOfObjectWithOptions:NSEnumerationConcurrent
-                                  passingTest:^BOOL(SentrySample *_Nonnull sample, NSUInteger idx,
-                                      BOOL *_Nonnull stop) {
-                                      *stop = sample.absoluteTimestamp >= transactionStart;
-                                      return *stop;
-                                  }];
+        [samples indexOfObjectWithOptions:NSEnumerationConcurrent
+                              passingTest:^BOOL(SentrySample *_Nonnull sample, NSUInteger idx,
+                                  BOOL *_Nonnull stop) {
+                                  *stop = sample.absoluteTimestamp >= transactionStart;
+                                  return *stop;
+                              }];
 
     if (firstIndex == NSNotFound) {
-        logSlicingFailureWithArray(samplesCopy, transaction, /*start*/ YES);
+        logSlicingFailureWithArray(samples, transaction, /*start*/ YES);
         return nil;
     } else {
         SENTRY_LOG_DEBUG(@"Found first slice sample at index %lu", firstIndex);
     }
 
     const auto transactionEnd = transaction.endSystemTime;
     const auto lastIndex =
-        [samplesCopy indexOfObjectWithOptions:NSEnumerationConcurrent | NSEnumerationReverse
-                                  passingTest:^BOOL(SentrySample *_Nonnull sample, NSUInteger idx,
-                                      BOOL *_Nonnull stop) {
-                                      *stop = sample.absoluteTimestamp <= transactionEnd;
-                                      return *stop;
-                                  }];
+        [samples indexOfObjectWithOptions:NSEnumerationConcurrent | NSEnumerationReverse
+                              passingTest:^BOOL(SentrySample *_Nonnull sample, NSUInteger idx,
+                                  BOOL *_Nonnull stop) {
+                                  *stop = sample.absoluteTimestamp <= transactionEnd;
+                                  return *stop;
+                              }];
 
     if (lastIndex == NSNotFound) {
-        logSlicingFailureWithArray(samplesCopy, transaction, /*start*/ NO);
+        logSlicingFailureWithArray(samples, transaction, /*start*/ NO);
         return nil;
     } else {
         SENTRY_LOG_DEBUG(@"Found last slice sample at index %lu", lastIndex);
     }
 
     const auto range = NSMakeRange(firstIndex, (lastIndex - firstIndex) + 1);
     const auto indices = [NSIndexSet indexSetWithIndexesInRange:range];
-    return [samplesCopy objectsAtIndexes:indices];
+    return [samples objectsAtIndexes:indices];
 }
 
 @implementation SentrySample