ref: Improve FileManager delete logs (#3514)

Delete file log messages show whether a file was successfully deleted, it doesn't exist, or an error occurred. Co-authored-by: Karl Heinz Struggl <[email protected]> Co-authored-by: Sentry Github Bot <[email protected]>
getsentry · Dec 19, 2023 · add9550 · add9550
1 parent fac579e
commit add9550
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/Sources/Sentry/SentryFileManager.m b/Sources/Sentry/SentryFileManager.m
@@ -239,13 +239,15 @@ - (void)removeFileAtPath:(NSString *)path
     NSFileManager *fileManager = [NSFileManager defaultManager];
     NSError *error = nil;
     @synchronized(self) {
-        SENTRY_LOG_DEBUG(@"Deleting %@", path);
-
         if (![fileManager removeItemAtPath:path error:&error]) {
-            // We don't want to log an error if the file doesn't exist.
-            if (error.code != NSFileNoSuchFileError) {
-                SENTRY_LOG_ERROR(@"Couldn't delete file %@: %@", path, error);
+            if (error.code == NSFileNoSuchFileError) {
+                SENTRY_LOG_DEBUG(@"No file to delete at %@", path);
+            } else {
+                SENTRY_LOG_ERROR(
+                    @"Error occurred while deleting file at %@ because of %@", path, error);
             }
+        } else {
+            SENTRY_LOG_DEBUG(@"Successfully deleted file at %@", path);
         }
     }
 }