Skip to content

Commit

Permalink
skip uninstall handler
Browse files Browse the repository at this point in the history
  • Loading branch information
philipphofmann committed May 31, 2024
1 parent 44b8edc commit fa756c6
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
- Add start time to network request breadcrumbs (#4008)
- Add C++ exception support for `__cxa_rethrow` (#3996)
- Add beforeCaptureScreenshot callback (#4016)
- Add option to enable SIGTERM reporting (#4025). We added support
- Disable SIGTERM reporting by default (#4025). We added support
for SIGTERM reporting in the last release and enabled it by default.
For some users, SIGTERM events were verbose and not actionable.
Therefore, we disable it per default in this release. If you'd like
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,11 @@ uninstallSignalHandler(void)
int fatalSignalsCount = sentrycrashsignal_numFatalSignals();

for (int i = 0; i < fatalSignalsCount; i++) {
if (fatalSignals[i] == SIGTERM && !g_isSigtermReportingEnabled) {
SentryCrashLOG_DEBUG("SIGTERM handling disabled. Skipping restoring handler.");
continue;
}

SentryCrashLOG_DEBUG("Restoring original handler for signal %d", fatalSignals[i]);
sigaction(fatalSignals[i], &g_previousSignalHandlers[i], NULL);
}
Expand Down

0 comments on commit fa756c6

Please sign in to comment.