-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Session Replay for iOS native apps #2616
Comments
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
We're doing a PoC of this as we speak. We should have some updates after the holidays |
Great work guys! Can't wait to see this feature on iOS. Your team's work is always top-notch. Even if there are any challenges along the way, it's great to witness these PoCs in progress. Keep up the excellent work! 👏🏼🚀 |
We released our first Alpha version of the SDK with support: https://github.com/getsentry/sentry-cocoa/releases/tag/8.24.0-alpha.0 To get access, it requires adding your Sentry org to our feature flag. This way data can be ingested and displayed in Sentry. |
Reopening because we had a first alpha but we'll keep this open until it's more generally available. |
I've given this a try to integrate into Flutter and I'm facing a couple of roadblocks so far:
Unfortunately, I don't feel confident enough with the codebase to make a PR with the changes so I hope someone could pick this up? |
|
I'm not sure that's going to work well. In order to capture a screenshot in Flutter on demand, we would need to schedule a callback to happen after a next frame and then wait for that (async) callback to finish. Because cocoa screenshot provider is a synchronous function that's supposed to return a value (image) it would need to block, right? If it's the only way we can use in the cocoa and you're opposed to changing to the way the java SDK does this than OK, let's try that, it just doesn't feel right. |
Not anymore, this is being updated in my ongoing PR.
It's not that I oppose to do it, it's a valid solution as the current one. I just dont think it's necessary to do it. We can change iOS for a new approach and then add Flutter support, or just add support to Flutter with the current approach. |
Hmm, how does that work? Is it different to what is done with the rest of the functionality in
I haven't found the PR so please let me know when that is available on the main branch. |
We create a But Im starting to believe that Flutter should have its own implementation of session replay since it has its own renderer. This way we wont have any dependencies in both native platforms and solve this with a dart only solution. |
I've considered that too, but with video encoding happening in native, it seemed to me that a mixed approach is a good way forward. With the java SDK, this works quite well so from my POV I don't see why this couldn't work with Cocoa as well. |
@vaind Sorry, I wont be able to help you with code anytime soon, Im focus in the native and RN side right now. But, the easy way to make |
Thanks, I'm looking into Android at the moment so it's fine. I'll let you know if anything changes and I end up moving more stuff to Flutter, as you've suggested, if it would make it easier to achieve the overall goal (across both native SDKs). |
@bruno-garcia, can we close this and keep track at getsentry/sentry#70065 ? |
During development of replay for Flutter, I'm often getting AFAICT it happens when I build the app via Flutter and later stop the flutter command in order to start the debug session in Xcode. |
Also, I get the same error repeatedly (every second) once the replay is sent due to an error. That is with both error replays and session replays at 1.0 |
That ticket tracks the Open Beta release. This has been useful to track the reactions to it as a signal of demand (outside the waitlist). We can close this after open beta but possibly GA is a better milesstone |
Support for Session Replay for Native iOS apps
Our goal is to support UIKit and SwiftUI. That means that apps rendering directly with Metal for example would not be supported.
Please let us know on the issue description if this aligns with what you need/expect.
We're working on it! Wanna join the early adopter release? Join the waitlist and discussion about the feature:
┆Issue is synchronized with this Jira Improvement by Unito
The text was updated successfully, but these errors were encountered: