-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: Use average color for redact masking #3877
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3877 +/- ##
=============================================
+ Coverage 90.690% 90.823% +0.132%
=============================================
Files 581 586 +5
Lines 45418 45778 +360
Branches 16162 16334 +172
=============================================
+ Hits 41190 41577 +387
- Misses 4048 4131 +83
+ Partials 180 70 -110
... and 49 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1e065bc | 1239.69 ms | 1258.18 ms | 18.49 ms |
6f4d20c | 1228.67 ms | 1238.88 ms | 10.21 ms |
61a1a2b | 1222.73 ms | 1245.35 ms | 22.62 ms |
add8416 | 1270.72 ms | 1300.38 ms | 29.66 ms |
98713e6 | 1211.48 ms | 1244.42 ms | 32.94 ms |
8f397a7 | 1196.55 ms | 1226.82 ms | 30.27 ms |
90d17d3 | 1261.18 ms | 1278.18 ms | 17.00 ms |
253bb71 | 1221.62 ms | 1250.82 ms | 29.20 ms |
a2af9fa | 1236.62 ms | 1253.12 ms | 16.50 ms |
effc81c | 1253.71 ms | 1256.16 ms | 2.45 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1e065bc | 20.76 KiB | 425.78 KiB | 405.01 KiB |
6f4d20c | 20.76 KiB | 431.71 KiB | 410.95 KiB |
61a1a2b | 21.58 KiB | 424.34 KiB | 402.76 KiB |
add8416 | 21.58 KiB | 541.91 KiB | 520.33 KiB |
98713e6 | 20.76 KiB | 435.22 KiB | 414.46 KiB |
8f397a7 | 20.76 KiB | 420.55 KiB | 399.79 KiB |
90d17d3 | 20.76 KiB | 432.17 KiB | 411.41 KiB |
253bb71 | 20.76 KiB | 393.37 KiB | 372.60 KiB |
a2af9fa | 20.76 KiB | 432.87 KiB | 412.11 KiB |
effc81c | 20.76 KiB | 433.18 KiB | 412.42 KiB |
Previous results on branch: feat(SR)/averagecolormasking
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e3a04fb | 1222.72 ms | 1244.85 ms | 22.13 ms |
6b8b5ea | 1240.14 ms | 1255.67 ms | 15.52 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e3a04fb | 21.58 KiB | 621.03 KiB | 599.45 KiB |
6b8b5ea | 21.58 KiB | 619.21 KiB | 597.62 KiB |
…entry-cocoa into feat(SR)/averagecolormasking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding more tests and extracting some code to make it testable 👍
Co-authored-by: Philipp Hofmann <[email protected]>
…entry-cocoa into feat(SR)/averagecolormasking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for including all the feedback.
hope we can ship this one Monday to unblock customers trialing who are affected by high CPU |
Use the text color or the average color of the image as the redaction mask. Co-authored-by: Philipp Hofmann <[email protected]>
Use the text color or the average color of the image as the redaction mask. Co-authored-by: Philipp Hofmann <[email protected]>
Use the text color or the average color of the image as the redaction mask.
#skip-changelog