Memory leaks

[vaibhavTM]

Platform

iOS

Installed

CocoaPods

Version

8.1.0

Steps to Reproduce

Just run the app

Expected Result

No memory leaks.

Actual Result

Are you willing to submit a PR?

No

[brustolin]

Thanks @vaibhavTM for reaching out. We're going to investigate this.

[vaibhavTM]

Thankyou @brustolin for quick response.

[vaibhavTM]

@brustolin Could you please confirm these issues exist in your SDK.

[brustolin]

Hello @vaibhavTM.
I experience a few leaks when profiling is enabled (@armcknight can you check this?).
But In the latest version of the SDK I could not produce any of the leaks in your screenshot.

Can you update your Sentry SDK version and let us know please?

[vaibhavTM]

Okay.

[brustolin]

Out of curiosity I tried the SDK 8.1 and I was able to see the leaks.
So, Im confident that the leaks in the screenshot are fixed.

We need to fixed leaks regarding profiling tho.

[vaibhavTM]

I am not able to update SDK above 8.1 via cocoapods.
my app's minimum iOS version support is iOS 11.0

This screenshot is of terminal when i did not give any SDK version in pod file. It automatically downloaded version 8.1.0

This screenshot is of terminal when I gave any Sentry SDK version 8.7.0 in pod file.

Please tell me how can I update to latest version using cocoapods

[philipphofmann]

@vaibhavTM, try run pod repo update and try again, please.

[vaibhavTM]

@philipphofmann this worked. Now I am at the latest version of SDK (8.7.0)
@brustolin When can I expect fixes of profiling leaks..?

[brustolin]

Profiling is a experimental feature right now, so please use it with caution, my guess is that this leaks will be fixed soon, but I can't give you an ETA.

[armcknight]

Thanks for writing in @vaibhavTM . I'm looking at the possible leaks from the profiler now. I tried an instruments run with our Swift-iOS test app, and started a manual transaction with profiling and let it go until the profiler timed out. There are some symbols for me to investigate related to profiling:

I hope to get updates on this today.

[vaibhavTM]

@armcknight okay.

[indragiek]

@armcknight @brustolin I made some progress tracking this down. Basically what appears to be happening is that we're capturing SentryProfilingState (previously just a bunch of arrays/dictionaries, but same idea) in the std::function that we pass to the SamplingProfiler initializer, but that captured state is never deallocated. It's not clear what's holding the reference to it - in the Xcode memory graph it looks like this:

Some memory that we can't identify (represented by the malloc) is holding a ref to it. I still have to dig deeper on this but if you have time to take a look this would be where to focus - I think it might be some weirdness with how C++ holds references to Objective-C objects.

[indragiek]

#3055 fixes all of these except for 1 leak

[indragiek]

@vaibhavTM We are cutting a new release with this fix soon.

[brustolin]

This was solved in 8.7.3