Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Don't only update App State in the OOM tracker #2276

Merged
merged 5 commits into from
Oct 13, 2022

Conversation

kevinrenskers
Copy link
Contributor

@kevinrenskers kevinrenskers commented Oct 12, 2022

📜 Description

Now the SentryAppStateManager is itself responsible for keep the app state up to date by listening to the various notifications. And both the OOM and AppStart trackers start this process, while making sure it's not started twice.

#skip-changelog (as nothing changes for the enduser)

💡 Motivation and Context

Closes #1149

💚 How did you test it?

Unit tests

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • Review from the native team if needed
  • No breaking changes

🔮 Next steps

@github-actions
Copy link

github-actions bot commented Oct 12, 2022

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1258.53 ms 1265.46 ms 6.93 ms
Size 20.50 KiB 333.88 KiB 313.38 KiB

Baseline results on branch: master

Startup times

Revision Plain With Sentry Diff
e958899 1230.40 ms 1248.31 ms 17.91 ms
e43ce74 1235.77 ms 1252.06 ms 16.29 ms
b172a8b 1257.68 ms 1272.38 ms 14.70 ms
b6ef18d 1248.35 ms 1270.16 ms 21.82 ms
3861500 1214.88 ms 1232.48 ms 17.60 ms
e958899 1233.02 ms 1261.86 ms 28.84 ms
a5ca27b 1231.31 ms 1252.56 ms 21.25 ms
c2a9b60 1222.10 ms 1240.62 ms 18.52 ms
c61d869 1255.92 ms 1267.47 ms 11.55 ms
8b040e4 1234.76 ms 1244.71 ms 9.95 ms

App size

Revision Plain With Sentry Diff
e958899 20.51 KiB 331.92 KiB 311.41 KiB
e43ce74 20.51 KiB 335.49 KiB 314.99 KiB
b172a8b 20.51 KiB 331.79 KiB 311.28 KiB
b6ef18d 20.51 KiB 332.90 KiB 312.40 KiB
3861500 20.50 KiB 333.54 KiB 313.04 KiB
e958899 20.51 KiB 331.92 KiB 311.41 KiB
a5ca27b 20.51 KiB 331.81 KiB 311.31 KiB
c2a9b60 20.50 KiB 333.54 KiB 313.04 KiB
c61d869 20.51 KiB 333.10 KiB 312.59 KiB
8b040e4 20.50 KiB 333.54 KiB 313.04 KiB

Previous results on branch: red/1149-saving-app-state

Startup times

Revision Plain With Sentry Diff
e849651 1240.18 ms 1255.88 ms 15.70 ms

App size

Revision Plain With Sentry Diff
e849651 20.50 KiB 333.88 KiB 313.38 KiB

@@ -19,6 +19,20 @@
/* End PBXBuildFile section */

/* Begin PBXContainerItemProxy section */
0A94157D28F6B893006A5DD1 /* PBXContainerItemProxy */ = {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why I got these changes in the project file for iOS-SwiftUI. I did open that project recently instead of iOS-Swift, I guess just opening it must've triggered something in Xcode?

Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinrenskers kevinrenskers merged commit 0e2e593 into master Oct 13, 2022
@kevinrenskers kevinrenskers deleted the red/1149-saving-app-state branch October 13, 2022 08:33
kevinrenskers added a commit that referenced this pull request Oct 13, 2022
* master:
  feat: Custom measurements API (#2268)
  ref: Don't only update App State in the OOM tracker (#2276)
  test: generate profiles with different levels of efficiency (#2274)
  test: disable testStartUpCrash_CallsFlush as it flakes (#2275)
  build(deps): bump github/codeql-action from 2.1.26 to 2.1.27 (#2272)
  ref: Use the new loadPreviousAppState in SentryAppStartTracker (#2261)
  test: use Test/TestCI configs for fastfile test runs (#2257)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix saving app state
2 participants