test: use a longer span to compare efficient implementations #2277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indragiek
approved these changes
Oct 12, 2022
armcknight
deleted the
armcknight/test/longer-span-for-efficiency-comparisons
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous PR introduced some inefficient implementations to the profile test data generator, so we can compare profiles for demo purposes (#2274). However, the spans it works with are too short. This introduces a span that runs the duration of a scroll operation in TrendingMovies' collection view, providing ample time to collect more information and hopefully produce profiles we can better use for demo purposes.
#skip-changelog