-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: testNoBreadcrumbForTextFieldEditingChanged flakiness #2992
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit surprised that this solves the problem, but if it does LGTM.
I should have make this a draft. Im trying options, and my assumption is that the simulator is slow and the test may execute faster than the app. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2992 +/- ##
=============================================
+ Coverage 80.565% 80.604% +0.039%
=============================================
Files 265 265
Lines 24709 24702 -7
Branches 10953 10945 -8
=============================================
+ Hits 19907 19911 +4
+ Misses 4186 4182 -4
+ Partials 616 609 -7 see 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
//Trigger a change in textfield | ||
app.buttons["editingChangedButton"].tap() | ||
|
||
Thread.sleep(forTimeInterval: 0.5) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
m
: Consider using waitForExistence
with a timeout instead, please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the problem is that there is nothing to "waitForExistence"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll rewrite the sample to dynamically create labels for every step. Overkill but it will solve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I was so fixed to use accessibilityIdentifier
that I forgot that is possible to wait for a label with a specific text.
Now it works, but I had to update the macOS and Xcode version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Solving testNoBreadcrumbForTextFieldEditingChanged flakiness in the CI simulator.
#skip-changelog