Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: testNoBreadcrumbForTextFieldEditingChanged flakiness #2992

Merged
merged 8 commits into from
May 4, 2023

Conversation

brustolin
Copy link
Contributor

Solving testNoBreadcrumbForTextFieldEditingChanged flakiness in the CI simulator.

#skip-changelog

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit surprised that this solves the problem, but if it does LGTM.

@brustolin
Copy link
Contributor Author

I'm a bit surprised that this solves the problem, but if it does LGTM.

I should have make this a draft. Im trying options, and my assumption is that the simulator is slow and the test may execute faster than the app.

@brustolin brustolin marked this pull request as draft May 3, 2023 09:46
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #2992 (209fced) into main (fd6a31c) will increase coverage by 0.039%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #2992       +/-   ##
=============================================
+ Coverage   80.565%   80.604%   +0.039%     
=============================================
  Files          265       265               
  Lines        24709     24702        -7     
  Branches     10953     10945        -8     
=============================================
+ Hits         19907     19911        +4     
+ Misses        4186      4182        -4     
+ Partials       616       609        -7     

see 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd6a31c...209fced. Read the comment docs.

//Trigger a change in textfield
app.buttons["editingChangedButton"].tap()

Thread.sleep(forTimeInterval: 0.5)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: Consider using waitForExistence with a timeout instead, please.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the problem is that there is nothing to "waitForExistence"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll rewrite the sample to dynamically create labels for every step. Overkill but it will solve

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I was so fixed to use accessibilityIdentifier that I forgot that is possible to wait for a label with a specific text.
Now it works, but I had to update the macOS and Xcode version.

@brustolin brustolin marked this pull request as ready for review May 4, 2023 06:16
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brustolin brustolin merged commit dc0fe58 into main May 4, 2023
@brustolin brustolin deleted the feat/fix-uitest branch May 4, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants