Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move breadcrumb tests to UITest #3038

Merged
merged 2 commits into from
May 16, 2023
Merged

Conversation

brustolin
Copy link
Contributor

Moved view info for breadcrumb unit test to ui tests.

close #3025

#skip-changelog

@github-actions
Copy link

github-actions bot commented May 16, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1227.72 ms 1237.87 ms 10.15 ms
Size 20.76 KiB 434.88 KiB 414.12 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
7c37d8e 1256.00 ms 1259.36 ms 3.36 ms
83d2d84 1211.31 ms 1227.34 ms 16.03 ms
b2f82fa 1236.94 ms 1262.86 ms 25.92 ms
1bf8571 1215.31 ms 1232.48 ms 17.17 ms
28333b6 1186.29 ms 1225.18 ms 38.89 ms
3f1be0f 1208.12 ms 1225.72 ms 17.60 ms
aeec206 1211.31 ms 1229.18 ms 17.87 ms
fd6a31c 1190.43 ms 1218.78 ms 28.35 ms
4c00f8c 1231.62 ms 1237.76 ms 6.14 ms
c6504da 1232.06 ms 1243.28 ms 11.22 ms

App size

Revision Plain With Sentry Diff
7c37d8e 20.76 KiB 426.86 KiB 406.09 KiB
83d2d84 20.76 KiB 419.66 KiB 398.90 KiB
b2f82fa 20.76 KiB 419.62 KiB 398.86 KiB
1bf8571 20.76 KiB 437.12 KiB 416.36 KiB
28333b6 20.76 KiB 424.69 KiB 403.93 KiB
3f1be0f 20.76 KiB 414.44 KiB 393.69 KiB
aeec206 20.76 KiB 434.88 KiB 414.12 KiB
fd6a31c 20.76 KiB 436.50 KiB 415.74 KiB
4c00f8c 20.76 KiB 419.62 KiB 398.86 KiB
c6504da 20.76 KiB 414.44 KiB 393.69 KiB

Previous results on branch: chore/breadcrumbtest-as-uitest

Startup times

Revision Plain With Sentry Diff
5ceeec2 1232.34 ms 1243.24 ms 10.90 ms

App size

Revision Plain With Sentry Diff
5ceeec2 20.76 KiB 434.88 KiB 414.12 KiB

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #3038 (23b94a2) into main (aeec206) will decrease coverage by 0.056%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3038       +/-   ##
=============================================
- Coverage   88.835%   88.780%   -0.056%     
=============================================
  Files          492       492               
  Lines        53063     53006       -57     
  Branches     19000     18968       -32     
=============================================
- Hits         47139     47059       -80     
- Misses        4964      4985       +21     
- Partials       960       962        +2     
Impacted Files Coverage Δ
...ons/Breadcrumbs/SentryBreadcrumbTrackerTests.swift 100.000% <ø> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeec206...23b94a2. Read the comment docs.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@brustolin brustolin merged commit c6773e5 into main May 16, 2023
@brustolin brustolin deleted the chore/breadcrumbtest-as-uitest branch May 16, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turn subset of BreadcrumbTrackerTests to UITests
2 participants