test: speed up some profiling tests #3134
Conversation
armcknight
changed the title
armcknight
force-pushed
the
armcknight/test/speed-up-profiling-tests
branch
from
5cfe118
to
b4c6629
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3134 +/- ##
=============================================
- Coverage 89.125% 89.092% -0.034%
=============================================
Files 500 499 -1
Lines 53963 53613 -350
Branches 19321 18987 -334
=============================================
- Hits 48095 47765 -330
- Misses 4900 4991 +91
+ Partials 968 857 -111
... and 84 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| @@ -47,8 +47,6 @@ - (void)testRetrievesThreadMetadata | |||
| SENTRY_PROF_LOG_ERROR_RETURN(pthread_setschedparam(thread, policy, ¶m)); | |||
| } | |||
|
|
|||
| std::this_thread::sleep_for(std::chrono::seconds(1)); | |||
There was a problem hiding this comment.
m: One CI job failed https://github.com/getsentry/sentry-cocoa/actions/runs/5483653476/jobs/9990243216?pr=3134 after removing the sleeps. Maybe we still need them.
There was a problem hiding this comment.
yeah looks like it! just much shorter than 1 second
After looking at the list of 20 slowest tests for a recent CI run, I realized some of the sleeps in profiler tests are unnecessary, and others are unnecessarily long.
#skip-changelog