Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove warning that spammed logs when called from display link callbacks #3284

Merged
merged 3 commits into from
Sep 18, 2023
Merged

fix: remove warning that spammed logs when called from display link callbacks #3284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c8ef551
fix: remove warning that spammed logs when called from display link c…
armcknight Sep 15, 2023
23b23d2
changelog
armcknight Sep 15, 2023
9cab488
Merge branch 'main' into armcknight/fix/remove-logspam
armcknight Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
- Fix how profiles were identified in the backend for grouping and issue correlation purposes (#3282)
- Ensure GPU frame data is always sent with profiles even if `enableAutoPerformanceTracing` is `NO` (#3273)
- Gather metric readings fully covering the duration of a profile (#3272)
- Remove spammy logs (#3284)

### Features

Expand Down
1 change: 0 additions & 1 deletion Sources/Sentry/SentryProfiler.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,6 @@ - (void)start
- (BOOL)isRunning
{
if (_profiler == nullptr) {
SENTRY_LOG_WARN(@"No profiler instance found.");
return NO;
}
return _profiler->isSampling();
Expand Down
Loading