Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: GA MetricKit integration #3340

Merged
merged 1 commit into from
Oct 12, 2023
Merged

feat: GA MetricKit integration #3340

merged 1 commit into from
Oct 12, 2023

Conversation

philipphofmann
Copy link
Member

📜 Description

Remove experimental note on options to make the MetricKit integration GA.

💡 Motivation and Context

Fixes GH-2585

💚 How did you test it?

Nothing to test for removing code comments.

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs: feat(apple): MetricKit GA sentry-docs#8186.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Remove experimental note on options to make the MetricKit
integration GA.

Fixes GH-2585
@github-actions
Copy link

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 612ec4f

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #3340 (612ec4f) into main (5b85619) will increase coverage by 0.063%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3340       +/-   ##
=============================================
+ Coverage   89.252%   89.316%   +0.063%     
=============================================
  Files          502       502               
  Lines        54488     54485        -3     
  Branches     19570     19566        -4     
=============================================
+ Hits         48632     48664       +32     
+ Misses        4987      4958       -29     
+ Partials       869       863        -6     

see 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b85619...612ec4f. Read the comment docs.

@github-actions
Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1220.47 ms 1241.12 ms 20.66 ms
Size 22.85 KiB 411.37 KiB 388.52 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
005bb4c 1237.38 ms 1255.54 ms 18.16 ms
d257eb9 1206.98 ms 1227.50 ms 20.52 ms
fb53d97 1226.08 ms 1245.12 ms 19.04 ms
60dd0f5 1238.98 ms 1254.48 ms 15.50 ms
fd6a31c 1190.43 ms 1218.78 ms 28.35 ms
d40512b 1231.12 ms 1244.54 ms 13.42 ms
5616e0a 1224.12 ms 1249.86 ms 25.74 ms
fc163f5 1219.18 ms 1242.74 ms 23.56 ms
25737cb 1235.02 ms 1250.06 ms 15.04 ms
4fc7fdf 1236.69 ms 1242.80 ms 6.11 ms

App size

Revision Plain With Sentry Diff
005bb4c 20.76 KiB 419.70 KiB 398.94 KiB
d257eb9 20.76 KiB 433.22 KiB 412.46 KiB
fb53d97 20.76 KiB 425.81 KiB 405.04 KiB
60dd0f5 20.76 KiB 393.37 KiB 372.61 KiB
fd6a31c 20.76 KiB 436.50 KiB 415.74 KiB
d40512b 20.76 KiB 427.77 KiB 407.00 KiB
5616e0a 22.85 KiB 407.44 KiB 384.59 KiB
fc163f5 20.76 KiB 436.29 KiB 415.53 KiB
25737cb 20.76 KiB 436.29 KiB 415.53 KiB
4fc7fdf 20.76 KiB 436.25 KiB 415.49 KiB

@philipphofmann philipphofmann enabled auto-merge (squash) October 12, 2023 13:32
@philipphofmann philipphofmann merged commit 2affdbd into main Oct 12, 2023
69 of 70 checks passed
@philipphofmann philipphofmann deleted the feat/metric-kit-ga branch October 12, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MetricKit MXDiagnosticPayload GA
2 participants