Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix typo in SentryTracer #3413

Merged
merged 1 commit into from
Nov 15, 2023
Merged

chore: Fix typo in SentryTracer #3413

merged 1 commit into from
Nov 15, 2023

Conversation

philipphofmann
Copy link
Member

#skip-changelog

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #3413 (de97f11) into main (ab0012c) will decrease coverage by 0.021%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3413       +/-   ##
=============================================
- Coverage   88.940%   88.919%   -0.021%     
=============================================
  Files          522       523        +1     
  Lines        56178     56415      +237     
  Branches     19984     20332      +348     
=============================================
+ Hits         49965     50164      +199     
- Misses        5288      5323       +35     
- Partials       925       928        +3     
Files Coverage Δ
Sources/Sentry/SentryTracer.m 96.600% <ø> (+0.399%) ⬆️

... and 70 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab0012c...de97f11. Read the comment docs.

@philipphofmann philipphofmann merged commit 1ce939e into main Nov 15, 2023
67 of 70 checks passed
@philipphofmann philipphofmann deleted the chore/fix-typo-tracer branch November 15, 2023 09:01
Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1243.78 ms 1254.52 ms 10.74 ms
Size 22.85 KiB 412.98 KiB 390.13 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
6f4d20c 1228.67 ms 1238.88 ms 10.21 ms
4bca912 1252.42 ms 1260.06 ms 7.64 ms
2124551 1265.50 ms 1276.44 ms 10.94 ms
7c5d161 1224.38 ms 1249.66 ms 25.28 ms
b868c3a 1238.45 ms 1254.98 ms 16.53 ms
ea73af6 1230.96 ms 1244.98 ms 14.02 ms
1db04d8 1250.20 ms 1258.12 ms 7.92 ms
1d11695 1219.57 ms 1243.52 ms 23.95 ms
a6f8b18 1238.54 ms 1265.56 ms 27.02 ms
51307b7 1223.08 ms 1240.76 ms 17.68 ms

App size

Revision Plain With Sentry Diff
6f4d20c 20.76 KiB 431.71 KiB 410.95 KiB
4bca912 22.85 KiB 411.14 KiB 388.29 KiB
2124551 22.85 KiB 411.69 KiB 388.84 KiB
7c5d161 20.76 KiB 414.44 KiB 393.68 KiB
b868c3a 22.85 KiB 411.17 KiB 388.32 KiB
ea73af6 20.76 KiB 425.75 KiB 404.99 KiB
1db04d8 20.76 KiB 435.50 KiB 414.74 KiB
1d11695 20.76 KiB 401.60 KiB 380.84 KiB
a6f8b18 20.76 KiB 431.87 KiB 411.11 KiB
51307b7 22.85 KiB 407.63 KiB 384.78 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants