-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Script to create a hot fix #3502
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sounds like this would be a new release process from just merging a PR to master, because we want to avoid shipping other new features along with a hotfix patch?
Could you add something to develop-docs/README.md that outlines the standard and hotfix processes?
Maybe it could also open a PR back into main
after pushing to $hotfix_branch
on line 22 using gh pr create
, or would that be done automatically from the release job?
From time to time, I am asked to do this, and I always forget how to. The script is designed to make it easy to create a hotfix release from one PR. This is not a process that we need to follow.
We don't need a new PR for hotfixes, all the code should have being reviewed already. |
@brustolin, I think we should rename the script to something like
@armcknight, there are multiple ways to create a hotfix; we don't have to use this script. You can also do the process manually. I'm okay with merging this if it makes releasing hotfixes easier for @brustolin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added a script that helps creating a hot fix from a specific version with a specific PR commit.
usage (from repo root directory):
To release 8.17.2 with #3501
After running the script we need to run the
release
action withhotfix/<new version>
branch forUse workflow from
#skip-changelog