Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(launch profiling): use dedicated traces instead of auto perf traces #3621

Merged
merged 55 commits into from
Feb 15, 2024
Merged

feat(launch profiling): use dedicated traces instead of auto perf traces #3621

merged 55 commits into from
Feb 15, 2024

Commits on Jan 30, 2024

  1. test: integration test for app launch profiling

    @armcknight
    armcknight committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    063bf35 View commit details
    Browse the repository at this point in the history

  2. fix integration tests after moving to a launch profiling marker file

    @armcknight
    armcknight committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    46341fd View commit details
    Browse the repository at this point in the history

  3. pr feedback: test new option's default value

    @armcknight
    armcknight committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    3893093 View commit details
    Browse the repository at this point in the history

  4. comment conditional complier closures

    @armcknight
    armcknight committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    ceddcd9 View commit details
    Browse the repository at this point in the history

  5. add unit tests for setting the option and option configurations

    @armcknight
    armcknight committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    7d8b5f7 View commit details
    Browse the repository at this point in the history

  6. fix tests after reimplementing writing the sample rates to the file

    @armcknight
    armcknight committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    98155c5 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'armcknight/feat/launch-profiling' into armcknight/test/… 

    …launch-profiling
    @armcknight
    armcknight committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    d24345a View commit details
    Browse the repository at this point in the history

  8. pr feedback: rename new var

    @armcknight
    armcknight committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    39efa27 View commit details
    Browse the repository at this point in the history

  9. pr feedback: iOS availability

    @armcknight
    armcknight committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    ca7127c View commit details
    Browse the repository at this point in the history

  10. pr feedback: don't include the test interface extension

    @armcknight
    armcknight committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    435a9eb View commit details
    Browse the repository at this point in the history

  11. fix macos build

    @armcknight
    armcknight committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    0422c94 View commit details
    Browse the repository at this point in the history

  12. pr feedback: move declaration from SentryFileManager test ext

    @armcknight
    armcknight committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    231d816 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. don't set isTracingAppLaunch to NO until after doing the work to pack… 

    …age up the profile

this is primarily to fix the integration test, but if there is any
    logic in the profiler that relies on the value of that variable,
    it needs to be correct
    @armcknight
    armcknight committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    17d006e View commit details
    Browse the repository at this point in the history

  2. only check for enableSwizzling in UIKit builds 

        since the only thing we need that is swizzled is the automatic UIViewController tracking
    @armcknight
    armcknight committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    4ef847b View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. test: manage files in sample app from integration test

    @armcknight
    armcknight committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    f715546 View commit details
    Browse the repository at this point in the history

  2. test: integration test fixes and additions

    @armcknight
    armcknight committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    9c143a7 View commit details
    Browse the repository at this point in the history

  3. logging

    @armcknight
    armcknight committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    7bc6c28 View commit details
    Browse the repository at this point in the history

  4. feat(app launch profiling): save sample rates config to backup

    @armcknight
    armcknight committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    8b854ec View commit details
    Browse the repository at this point in the history

  5. Merge branch 'armcknight/feat/launch-profiling' into armcknight/test/… 

    …launch-profiling
    @armcknight
    armcknight committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    251338a View commit details
    Browse the repository at this point in the history

  6. Merge branch 'armcknight/test/launch-profiling' into armcknight/test/… 

    …launch-profiling2
    @armcknight
    armcknight committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    6c9c344 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'armcknight/test/launch-profiling2' into armcknight/test… 

    …/launch-profiling3
    @armcknight
    armcknight committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    66905ed View commit details
    Browse the repository at this point in the history

  8. Merge branch 'armcknight/test/launch-profiling3' into armcknight/feat… 

    …/launch-profiling2
    @armcknight
    armcknight committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    c544ea7 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. pr feedback: tests, edge cases and refactor/reuse file removal logic

    @armcknight
    armcknight committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    3574494 View commit details
    Browse the repository at this point in the history

  2. wip: need to thread the stored sample rate to isTracingEnabled or whe… 

    …re its used for the uivc tracker installation
    @armcknight
    armcknight committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    15f4b7b View commit details
    Browse the repository at this point in the history

  3. pr feedback: rename

    @armcknight
    armcknight committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    2fd98c0 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Merge branch 'armcknight/feat/launch-profiling' into armcknight/test/… 

    …launch-profiling
    @armcknight
    armcknight committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    522379d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'armcknight/test/launch-profiling' into armcknight/test/… 

    …launch-profiling2
    @armcknight
    armcknight committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    e4ae98b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'armcknight/test/launch-profiling2' into armcknight/test… 

    …/launch-profiling3
    @armcknight
    armcknight committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    155ca7f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'armcknight/test/launch-profiling3' into armcknight/feat… 

    …/launch-profiling2
    @armcknight
    armcknight committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    5beb31c View commit details
    Browse the repository at this point in the history

  5. fix test on macos (isnt applicable)

    @armcknight
    armcknight committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    3af711b View commit details
    Browse the repository at this point in the history

  6. add availability declaration to fix some ui tests that are failing to… 

    … build due to the async setUp override
    @armcknight
    armcknight committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    b799c57 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'armcknight/feat/launch-profiling' into armcknight/test/… 

    …launch-profiling
    @armcknight
    armcknight committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    af92442 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'armcknight/test/launch-profiling' into armcknight/test/… 

    …launch-profiling2
    @armcknight
    armcknight committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    2fe9785 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'armcknight/test/launch-profiling2' into armcknight/test… 

    …/launch-profiling3
    @armcknight
    armcknight committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    b08b5fc View commit details
    Browse the repository at this point in the history

  10. Merge branch 'armcknight/test/launch-profiling3' into armcknight/feat… 

    …/launch-profiling2
    @armcknight
    armcknight committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    4e1b039 View commit details
    Browse the repository at this point in the history

  11. wip

    @armcknight
    armcknight committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    b79b303 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. wip moving to starting a trace for the launch profile instead storing… 

    … the sample rates to inject into a ui.load trace
    @armcknight
    armcknight committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    854d063 View commit details
    Browse the repository at this point in the history

  2. put back hub the way it was

    @armcknight
    armcknight committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    f249844 View commit details
    Browse the repository at this point in the history

  3. remove the need for a backup config file 

    since we're no longer threading the sample rates to the first transaction created after SentrySDK.start where we can wind up with mismatched sample rates
    @armcknight
    armcknight committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    6cd924a View commit details
    Browse the repository at this point in the history

  4. remainder of conversion to creating dedicated launch traces 

    put back tracer init logic to previous state

stop profiled traces in calls to SentrySDK.startWithOptions
    @armcknight
    armcknight committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    266d060 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'armcknight/feat/launch-profiling2' into armcknight/feat… 

    …/launch-profiling3-create-dedicated-launch-traces
    @armcknight
    armcknight committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    26f62c3 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'armcknight/feat/launch-profiling' into armcknight/test/… 

    …launch-profiling
    @armcknight
    armcknight committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    21ac5d3 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'armcknight/feat/launch-profiling' into armcknight/test/… 

    …launch-profiling2
    @armcknight
    armcknight committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    bf12020 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'armcknight/test/launch-profiling' into armcknight/test/… 

    …launch-profiling2
    @armcknight
    armcknight committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    97de0c4 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'armcknight/test/launch-profiling2' into armcknight/test… 

    …/launch-profiling3
    @armcknight
    armcknight committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    a931f3a View commit details
    Browse the repository at this point in the history

  10. Merge branch 'armcknight/test/launch-profiling3' into armcknight/feat… 

    …/launch-profiling2
    @armcknight
    armcknight committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    af86ee9 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'armcknight/feat/launch-profiling2' into armcknight/feat… 

    …/launch-profiling3-create-dedicated-launch-traces
    @armcknight
    armcknight committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    1717ae1 View commit details
    Browse the repository at this point in the history

  12. wip: debug why SlowLoad frames don't appear in flamegraphs

    @armcknight
    armcknight committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    a69b25e View commit details
    Browse the repository at this point in the history

  13. Merge branch 'armcknight/feat/launch-profiling' into armcknight/feat/… 

    …launch-profiling3-create-dedicated-launch-traces
    @armcknight
    armcknight committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    cc31af8 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. fix merge conflict resolutions

    @armcknight
    armcknight committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    715eaf7 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. remove requirements on auto perf, swizzling and uivc tracking

    @armcknight
    armcknight committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    9ff69f0 View commit details
    Browse the repository at this point in the history

  2. update unit tests

    @armcknight
    armcknight committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    e28778c View commit details
    Browse the repository at this point in the history

  3. remove nullable annotation

    @armcknight
    armcknight committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    e642a91 View commit details
    Browse the repository at this point in the history

  4. fix(launch profiling): fix data wipe between integration test runs (#… 

    …3633)

Co-authored-by: Philipp Hofmann <[email protected]>
    @armcknight @philipphofmann
    armcknight and philipphofmann authored Feb 15, 2024
    Configuration menu
    Copy the full SHA
    f45a7f7 View commit details
    Browse the repository at this point in the history

  5. fix changelog

    @armcknight
    armcknight committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    807ac47 View commit details
    Browse the repository at this point in the history