-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for Sentry Spotlight #3642
Conversation
Add the possibility to add multiple transports in the TransportAdapter, which is internal. This is a preparation for adding support for Spotlight.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3642 +/- ##
=============================================
+ Coverage 89.213% 89.272% +0.059%
=============================================
Files 532 534 +2
Lines 58722 58972 +250
Branches 21077 21163 +86
=============================================
+ Hits 52388 52646 +258
+ Misses 5297 5294 -3
+ Partials 1037 1032 -5
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
11b2ffa | 1204.86 ms | 1218.16 ms | 13.31 ms |
8c50edb | 1212.98 ms | 1233.72 ms | 20.74 ms |
e778bd2 | 1224.66 ms | 1252.16 ms | 27.50 ms |
4d3df92 | 1235.18 ms | 1252.29 ms | 17.10 ms |
556c407 | 1256.56 ms | 1274.60 ms | 18.04 ms |
0d32275 | 1215.31 ms | 1240.19 ms | 24.88 ms |
af1f4dd | 1207.33 ms | 1230.04 ms | 22.71 ms |
034be1c | 1222.67 ms | 1236.22 ms | 13.55 ms |
0559a8f | 1212.37 ms | 1232.12 ms | 19.76 ms |
881a955 | 1222.16 ms | 1237.22 ms | 15.06 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
11b2ffa | 22.85 KiB | 412.67 KiB | 389.82 KiB |
8c50edb | 20.76 KiB | 432.31 KiB | 411.55 KiB |
e778bd2 | 20.76 KiB | 426.15 KiB | 405.39 KiB |
4d3df92 | 22.85 KiB | 413.44 KiB | 390.59 KiB |
556c407 | 22.85 KiB | 413.98 KiB | 391.13 KiB |
0d32275 | 22.84 KiB | 403.14 KiB | 380.29 KiB |
af1f4dd | 22.85 KiB | 414.71 KiB | 391.86 KiB |
034be1c | 20.76 KiB | 436.66 KiB | 415.90 KiB |
0559a8f | 21.58 KiB | 419.81 KiB | 398.22 KiB |
881a955 | 22.85 KiB | 407.63 KiB | 384.78 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
A few non blocking suggestions.
📜 Description
Add support for sending SDK events to Spotlight.
This PR is based on #3641.
💡 Motivation and Context
Fixes the Cocoa part of #3491.
💚 How did you test it?
Unit tests and manually sending events to a locally running Spotlight instance.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps