-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Set orientation portrait for UI tests #3656
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some failing benchmark tests in SauceLabs show the devices in landscape mode. All other UI tests use portrait mode. Now, also the SentrySDKPerformanceBenchmarkTests.
philipphofmann
requested review from
brustolin and
armcknight
as code owners
February 19, 2024 09:15
philipphofmann
changed the title
test: Set orientation portrait for benchmark tests
test: Set orientation portrait for UI tests
Feb 19, 2024
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
11b2ffa | 1204.86 ms | 1218.16 ms | 13.31 ms |
8c50edb | 1212.98 ms | 1233.72 ms | 20.74 ms |
e778bd2 | 1224.66 ms | 1252.16 ms | 27.50 ms |
4d3df92 | 1235.18 ms | 1252.29 ms | 17.10 ms |
556c407 | 1256.56 ms | 1274.60 ms | 18.04 ms |
0d32275 | 1215.31 ms | 1240.19 ms | 24.88 ms |
af1f4dd | 1207.33 ms | 1230.04 ms | 22.71 ms |
034be1c | 1222.67 ms | 1236.22 ms | 13.55 ms |
0559a8f | 1212.37 ms | 1232.12 ms | 19.76 ms |
881a955 | 1222.16 ms | 1237.22 ms | 15.06 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
11b2ffa | 22.85 KiB | 412.67 KiB | 389.82 KiB |
8c50edb | 20.76 KiB | 432.31 KiB | 411.55 KiB |
e778bd2 | 20.76 KiB | 426.15 KiB | 405.39 KiB |
4d3df92 | 22.85 KiB | 413.44 KiB | 390.59 KiB |
556c407 | 22.85 KiB | 413.98 KiB | 391.13 KiB |
0d32275 | 22.84 KiB | 403.14 KiB | 380.29 KiB |
af1f4dd | 22.85 KiB | 414.71 KiB | 391.86 KiB |
034be1c | 20.76 KiB | 436.66 KiB | 415.90 KiB |
0559a8f | 21.58 KiB | 419.81 KiB | 398.22 KiB |
881a955 | 22.85 KiB | 407.63 KiB | 384.78 KiB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3656 +/- ##
=============================================
+ Coverage 89.262% 89.328% +0.065%
=============================================
Files 534 534
Lines 58972 58978 +6
Branches 21161 21166 +5
=============================================
+ Hits 52640 52684 +44
+ Misses 5295 5265 -30
+ Partials 1037 1029 -8 see 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
brustolin
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some failing benchmark tests in SauceLabs show the devices in landscape mode. The
SentrySDKPerformanceBenchmarkTests
now use portrait mode.#skip-changelog