Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Set orientation portrait for UI tests #3656

Merged
merged 5 commits into from
Feb 19, 2024

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Feb 19, 2024

Some failing benchmark tests in SauceLabs show the devices in landscape mode. TheSentrySDKPerformanceBenchmarkTests now use portrait mode.

#skip-changelog

Some failing benchmark tests in SauceLabs show the devices in landscape
mode. All other UI tests use portrait mode. Now, also the
SentrySDKPerformanceBenchmarkTests.
@philipphofmann philipphofmann changed the title test: Set orientation portrait for benchmark tests test: Set orientation portrait for UI tests Feb 19, 2024
Copy link

github-actions bot commented Feb 19, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1220.69 ms 1228.68 ms 7.99 ms
Size 21.58 KiB 424.30 KiB 402.71 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
11b2ffa 1204.86 ms 1218.16 ms 13.31 ms
8c50edb 1212.98 ms 1233.72 ms 20.74 ms
e778bd2 1224.66 ms 1252.16 ms 27.50 ms
4d3df92 1235.18 ms 1252.29 ms 17.10 ms
556c407 1256.56 ms 1274.60 ms 18.04 ms
0d32275 1215.31 ms 1240.19 ms 24.88 ms
af1f4dd 1207.33 ms 1230.04 ms 22.71 ms
034be1c 1222.67 ms 1236.22 ms 13.55 ms
0559a8f 1212.37 ms 1232.12 ms 19.76 ms
881a955 1222.16 ms 1237.22 ms 15.06 ms

App size

Revision Plain With Sentry Diff
11b2ffa 22.85 KiB 412.67 KiB 389.82 KiB
8c50edb 20.76 KiB 432.31 KiB 411.55 KiB
e778bd2 20.76 KiB 426.15 KiB 405.39 KiB
4d3df92 22.85 KiB 413.44 KiB 390.59 KiB
556c407 22.85 KiB 413.98 KiB 391.13 KiB
0d32275 22.84 KiB 403.14 KiB 380.29 KiB
af1f4dd 22.85 KiB 414.71 KiB 391.86 KiB
034be1c 20.76 KiB 436.66 KiB 415.90 KiB
0559a8f 21.58 KiB 419.81 KiB 398.22 KiB
881a955 22.85 KiB 407.63 KiB 384.78 KiB

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eff9311) 89.262% compared to head (89c3f4d) 89.328%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3656       +/-   ##
=============================================
+ Coverage   89.262%   89.328%   +0.065%     
=============================================
  Files          534       534               
  Lines        58972     58978        +6     
  Branches     21161     21166        +5     
=============================================
+ Hits         52640     52684       +44     
+ Misses        5295      5265       -30     
+ Partials      1037      1029        -8     

see 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eff9311...89c3f4d. Read the comment docs.

@philipphofmann philipphofmann merged commit 01ea580 into main Feb 19, 2024
64 of 67 checks passed
@philipphofmann philipphofmann deleted the test/portrait-benchmark branch February 19, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants