Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hybrid): Make SentryFramesTracker available for HybridSDKs #3683

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

krystofwoldrich
Copy link
Member

📜 Description

The SentryFramesTracker is needed for frames tracking on Hybrid SDKs.

💚 How did you test it?

local build, ci

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link

github-actions bot commented Feb 27, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1202.63 ms 1220.53 ms 17.90 ms
Size 21.58 KiB 424.35 KiB 402.76 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c00eafe 1253.04 ms 1256.41 ms 3.37 ms
fb7eecf 1197.55 ms 1228.57 ms 31.02 ms
20742ca 1225.69 ms 1243.71 ms 18.01 ms
881a955 1214.27 ms 1235.88 ms 21.61 ms
3f6c30b 1252.98 ms 1266.22 ms 13.24 ms
f8833c4 1229.69 ms 1236.45 ms 6.76 ms
efb2222 1256.44 ms 1278.90 ms 22.46 ms
60dd0f5 1238.98 ms 1254.48 ms 15.50 ms
e0291c9 1242.98 ms 1253.08 ms 10.10 ms
c2acec5 1200.60 ms 1227.08 ms 26.48 ms

App size

Revision Plain With Sentry Diff
c00eafe 20.76 KiB 432.88 KiB 412.12 KiB
fb7eecf 22.85 KiB 411.37 KiB 388.52 KiB
20742ca 21.58 KiB 417.87 KiB 396.28 KiB
881a955 22.85 KiB 407.63 KiB 384.78 KiB
3f6c30b 22.85 KiB 408.88 KiB 386.03 KiB
f8833c4 21.58 KiB 422.66 KiB 401.08 KiB
efb2222 20.76 KiB 424.45 KiB 403.69 KiB
60dd0f5 20.76 KiB 393.37 KiB 372.61 KiB
e0291c9 22.85 KiB 413.50 KiB 390.65 KiB
c2acec5 22.85 KiB 408.88 KiB 386.03 KiB

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.311%. Comparing base (939cd63) to head (f68958a).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3683       +/-   ##
=============================================
+ Coverage   89.292%   89.311%   +0.018%     
=============================================
  Files          534       534               
  Lines        58987     58987               
  Branches     21176     21175        -1     
=============================================
+ Hits         52671     52682       +11     
+ Misses        5282      5272       -10     
+ Partials      1034      1033        -1     

see 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 939cd63...f68958a. Read the comment docs.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krystofwoldrich krystofwoldrich merged commit a716092 into main Feb 27, 2024
69 of 70 checks passed
threema-matteo pushed a commit to threema-ch/sentry-cocoa that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants