-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: Uncouple DependencyContainer from SentryHub #3698
Conversation
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3f366ee | 1242.28 ms | 1260.80 ms | 18.52 ms |
fc163f5 | 1224.17 ms | 1248.24 ms | 24.08 ms |
e8b11f8 | 1233.66 ms | 1249.74 ms | 16.08 ms |
8636ef0 | 1239.96 ms | 1253.14 ms | 13.18 ms |
fcde045 | 1260.71 ms | 1275.00 ms | 14.29 ms |
f8833c4 | 1236.45 ms | 1252.82 ms | 16.37 ms |
28c80b5 | 1198.63 ms | 1214.08 ms | 15.45 ms |
dd0557f | 1246.31 ms | 1258.46 ms | 12.15 ms |
60dd0f5 | 1247.35 ms | 1267.59 ms | 20.24 ms |
e0f077c | 1224.65 ms | 1243.52 ms | 18.87 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3f366ee | 20.76 KiB | 427.84 KiB | 407.08 KiB |
fc163f5 | 20.76 KiB | 436.30 KiB | 415.54 KiB |
e8b11f8 | 22.85 KiB | 411.92 KiB | 389.07 KiB |
8636ef0 | 22.84 KiB | 403.18 KiB | 380.34 KiB |
fcde045 | 20.76 KiB | 435.26 KiB | 414.50 KiB |
f8833c4 | 21.58 KiB | 422.66 KiB | 401.08 KiB |
28c80b5 | 21.58 KiB | 417.85 KiB | 396.27 KiB |
dd0557f | 22.85 KiB | 411.75 KiB | 388.90 KiB |
60dd0f5 | 20.76 KiB | 393.37 KiB | 372.60 KiB |
e0f077c | 22.85 KiB | 412.59 KiB | 389.74 KiB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3698 +/- ##
=============================================
- Coverage 89.287% 89.248% -0.039%
=============================================
Files 534 534
Lines 58940 58952 +12
Branches 21153 21158 +5
=============================================
- Hits 52626 52614 -12
- Misses 5280 5300 +20
- Partials 1034 1038 +4
... and 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense. Thanks 👍
Removed SentryHub dependency from SentryDependencyContainer to avoid cyclic reference that caused a problem in this PR.
Removed SentryHub dependency from SentryDependencyContainer to avoid cyclic reference that caused a problem in this PR.
#skip-changelog