Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Swift Sentry Integration #3733

Merged
merged 8 commits into from
Mar 14, 2024
Merged

Conversation

brustolin
Copy link
Contributor

Moved SentryIntegrationProtocol to swift and fixed some headers references in order to be able to write new integrations in Swift.

Required for Session Replay

#skip-changelog

Copy link

github-actions bot commented Mar 12, 2024

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • Sources/Sentry/SentryNetworkTracker.m

Copy link

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • Sources/Sentry/SentryNetworkTracker.m

Copy link

github-actions bot commented Mar 12, 2024

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • Sources/Sentry/SentryNetworkTracker.m

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 89.354%. Comparing base (7fe37ab) to head (45b4f00).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3733       +/-   ##
=============================================
+ Coverage   89.349%   89.354%   +0.005%     
=============================================
  Files          536       538        +2     
  Lines        59076     59126       +50     
  Branches     21228     21251       +23     
=============================================
+ Hits         52784     52832       +48     
- Misses        5250      5258        +8     
+ Partials      1042      1036        -6     
Files Coverage Δ
Sources/Sentry/PrivateSentrySDKOnly.mm 87.155% <ø> (ø)
Sources/Sentry/SentryAppStartTrackingIntegration.m 100.000% <ø> (ø)
Sources/Sentry/SentryBaseIntegration.m 96.000% <100.000%> (+0.065%) ⬆️
Sources/Sentry/SentryCrashIntegration.m 97.938% <ø> (ø)
Sources/Sentry/SentryHub.m 98.520% <ø> (ø)
Sources/Sentry/SentryMetricKitIntegration.m 99.583% <ø> (ø)
Sources/Sentry/SentryNSURLRequest.m 80.000% <ø> (ø)
Sources/Sentry/SentryNetworkTracker.m 91.935% <ø> (ø)
...rces/Sentry/SentryPerformanceTrackingIntegration.m 100.000% <ø> (ø)
Sources/Sentry/SentryProfiler.mm 77.862% <ø> (ø)
... and 8 more

... and 16 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fe37ab...45b4f00. Read the comment docs.

Copy link

github-actions bot commented Mar 12, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1205.59 ms 1215.33 ms 9.73 ms
Size 21.58 KiB 542.39 KiB 520.80 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
4d3df92 1218.27 ms 1248.30 ms 30.03 ms
881a955 1230.98 ms 1246.22 ms 15.24 ms
0d32275 1215.31 ms 1240.19 ms 24.88 ms
a71f5e2 1239.92 ms 1250.67 ms 10.76 ms
b9a9dca 1196.09 ms 1225.14 ms 29.05 ms
4a947cf 1230.73 ms 1239.38 ms 8.65 ms
c319795 1205.12 ms 1231.20 ms 26.08 ms
dc0fe58 1198.56 ms 1220.98 ms 22.42 ms
f0283e8 1245.92 ms 1262.82 ms 16.90 ms
bd2afa6 1192.31 ms 1210.37 ms 18.05 ms

App size

Revision Plain With Sentry Diff
4d3df92 22.85 KiB 413.45 KiB 390.60 KiB
881a955 22.85 KiB 407.63 KiB 384.79 KiB
0d32275 22.84 KiB 403.14 KiB 380.29 KiB
a71f5e2 21.58 KiB 424.34 KiB 402.76 KiB
b9a9dca 21.58 KiB 414.59 KiB 393.01 KiB
4a947cf 20.76 KiB 399.69 KiB 378.92 KiB
c319795 20.76 KiB 431.99 KiB 411.22 KiB
dc0fe58 20.76 KiB 436.50 KiB 415.74 KiB
f0283e8 20.76 KiB 393.37 KiB 372.61 KiB
bd2afa6 20.76 KiB 420.55 KiB 399.79 KiB

Previous results on branch: chore/SentryIntegration-for-swift

Startup times

Revision Plain With Sentry Diff
b3f2b49 1230.25 ms 1246.52 ms 16.27 ms

App size

Revision Plain With Sentry Diff
b3f2b49 21.58 KiB 542.38 KiB 520.80 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

Sources/Sentry/include/SentryIntegrationProtocol.h Outdated Show resolved Hide resolved
Tests/SentryTests/SentrySDKTests.swift Show resolved Hide resolved
Copy link

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • Sources/Sentry/SentryNetworkTracker.m

@brustolin brustolin enabled auto-merge (squash) March 14, 2024 13:06
@brustolin brustolin merged commit 2de284c into main Mar 14, 2024
69 of 70 checks passed
@brustolin brustolin deleted the chore/SentryIntegration-for-swift branch March 14, 2024 13:06
threema-matteo pushed a commit to threema-ch/sentry-cocoa that referenced this pull request May 21, 2024
Moved SentryIntegrationProtocol to swift and fixed some headers references in order to be able to write new integrations in Swift.

Required for Session Replay
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants