-
-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Swift Sentry Integration #3733
Conversation
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
…try/sentry-cocoa into chore/SentryIntegration-for-swift
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3733 +/- ##
=============================================
+ Coverage 89.349% 89.354% +0.005%
=============================================
Files 536 538 +2
Lines 59076 59126 +50
Branches 21228 21251 +23
=============================================
+ Hits 52784 52832 +48
- Misses 5250 5258 +8
+ Partials 1042 1036 -6
... and 16 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
4d3df92 | 1218.27 ms | 1248.30 ms | 30.03 ms |
881a955 | 1230.98 ms | 1246.22 ms | 15.24 ms |
0d32275 | 1215.31 ms | 1240.19 ms | 24.88 ms |
a71f5e2 | 1239.92 ms | 1250.67 ms | 10.76 ms |
b9a9dca | 1196.09 ms | 1225.14 ms | 29.05 ms |
4a947cf | 1230.73 ms | 1239.38 ms | 8.65 ms |
c319795 | 1205.12 ms | 1231.20 ms | 26.08 ms |
dc0fe58 | 1198.56 ms | 1220.98 ms | 22.42 ms |
f0283e8 | 1245.92 ms | 1262.82 ms | 16.90 ms |
bd2afa6 | 1192.31 ms | 1210.37 ms | 18.05 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
4d3df92 | 22.85 KiB | 413.45 KiB | 390.60 KiB |
881a955 | 22.85 KiB | 407.63 KiB | 384.79 KiB |
0d32275 | 22.84 KiB | 403.14 KiB | 380.29 KiB |
a71f5e2 | 21.58 KiB | 424.34 KiB | 402.76 KiB |
b9a9dca | 21.58 KiB | 414.59 KiB | 393.01 KiB |
4a947cf | 20.76 KiB | 399.69 KiB | 378.92 KiB |
c319795 | 20.76 KiB | 431.99 KiB | 411.22 KiB |
dc0fe58 | 20.76 KiB | 436.50 KiB | 415.74 KiB |
f0283e8 | 20.76 KiB | 393.37 KiB | 372.61 KiB |
bd2afa6 | 20.76 KiB | 420.55 KiB | 399.79 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM.
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
Moved SentryIntegrationProtocol to swift and fixed some headers references in order to be able to write new integrations in Swift. Required for Session Replay
Moved
SentryIntegrationProtocol
to swift and fixed some headers references in order to be able to write new integrations in Swift.Required for Session Replay
#skip-changelog