-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(profiling): put back some unnecessarily prefixed functions #3882
ref(profiling): put back some unnecessarily prefixed functions #3882
Conversation
…g underscore for public members
…continuous-profiling/4-refactoring/3-renames
…/3-renames' into armcknight/feat/3555-continuous-profiling/4-refactoring/4-extract-sdk-start-profiling-tasks
…/4-extract-sdk-start-profiling-tasks' into armcknight/feat/3555-continuous-profiling/4-refactoring/5-profile-serialization
…continuous-profiling/4-refactoring/5-profile-serialization
This reverts commit 9a9d689.
…/5-profile-serialization' into armcknight/feat/3555-continuous-profiling/4-refactoring/6-re-renames
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3882 +/- ##
=============================================
- Coverage 90.626% 90.608% -0.018%
=============================================
Files 582 582
Lines 45469 45468 -1
Branches 16187 16189 +2
=============================================
- Hits 41207 41198 -9
- Misses 4192 4200 +8
Partials 70 70
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
dd4145f | 1233.48 ms | 1254.35 ms | 20.88 ms |
aa4eddf | 1228.21 ms | 1236.72 ms | 8.51 ms |
eb077dd | 1229.49 ms | 1241.11 ms | 11.62 ms |
2124551 | 1231.78 ms | 1264.94 ms | 33.16 ms |
0d32275 | 1215.31 ms | 1240.19 ms | 24.88 ms |
4d3df92 | 1245.35 ms | 1259.58 ms | 14.23 ms |
326b7eb | 1223.41 ms | 1235.66 ms | 12.25 ms |
e8b11f8 | 1233.66 ms | 1249.74 ms | 16.08 ms |
7512778 | 1200.78 ms | 1206.33 ms | 5.55 ms |
188547e | 1241.47 ms | 1257.35 ms | 15.88 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
dd4145f | 21.58 KiB | 540.09 KiB | 518.51 KiB |
aa4eddf | 21.58 KiB | 544.86 KiB | 523.28 KiB |
eb077dd | 21.58 KiB | 614.00 KiB | 592.41 KiB |
2124551 | 22.85 KiB | 411.69 KiB | 388.84 KiB |
0d32275 | 22.84 KiB | 403.14 KiB | 380.29 KiB |
4d3df92 | 22.85 KiB | 413.45 KiB | 390.60 KiB |
326b7eb | 20.76 KiB | 432.31 KiB | 411.55 KiB |
e8b11f8 | 22.85 KiB | 411.92 KiB | 389.07 KiB |
7512778 | 21.58 KiB | 539.87 KiB | 518.29 KiB |
188547e | 21.58 KiB | 424.34 KiB | 402.76 KiB |
Previous results on branch: armcknight/feat/3555-continuous-profiling/4-refactoring/6-re-renames
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
611fb67 | 1226.35 ms | 1252.14 ms | 25.80 ms |
3f7cef5 | 1235.16 ms | 1258.44 ms | 23.27 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
611fb67 | 21.58 KiB | 614.78 KiB | 593.20 KiB |
3f7cef5 | 21.58 KiB | 615.09 KiB | 593.51 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…continuous-profiling/4-refactoring/6-re-renames
…continuous-profiling/4-refactoring/6-re-renames
Reverts some unnecessary renames from #3874. Also move a few more things to static scope, as that PR did, to avoid more possibilities to collide with customer symbols.
for #3555; #skip-changelog