-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: Ignore more thread sanitizer warnings in code #3923
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ThreadSanitizer reports data races for the SentryFramesTracker, which we can ignore. Fixes GH-3702
Ignore the thread sanitizer in the code where possible, which has the advantage of knowing a method is ignored when reading the code and not jumping to the ThreadSanitizer.sup file. Furthermore, use the ThreadSanitizer.sup file not only for tests but for the Run Xcode schemes.
philipphofmann
commented
Apr 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3923 +/- ##
=============================================
- Coverage 90.687% 90.648% -0.039%
=============================================
Files 582 582
Lines 45521 45524 +3
Branches 16220 16223 +3
=============================================
- Hits 41282 41267 -15
- Misses 4060 4075 +15
- Partials 179 182 +3
... and 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
03d9eb5 | 1227.35 ms | 1231.24 ms | 3.90 ms |
6813f7c | 1232.23 ms | 1251.47 ms | 19.24 ms |
c6773e5 | 1222.48 ms | 1240.02 ms | 17.54 ms |
236d8a8 | 1232.33 ms | 1255.55 ms | 23.22 ms |
0001a09 | 1223.90 ms | 1249.56 ms | 25.66 ms |
591a01b | 1197.94 ms | 1222.53 ms | 24.59 ms |
645f63f | 1231.33 ms | 1247.51 ms | 16.18 ms |
f0283e8 | 1253.36 ms | 1263.12 ms | 9.76 ms |
1ce939e | 1216.79 ms | 1242.38 ms | 25.59 ms |
60dd0f5 | 1239.94 ms | 1252.54 ms | 12.60 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
03d9eb5 | 20.76 KiB | 436.33 KiB | 415.57 KiB |
6813f7c | 21.58 KiB | 614.86 KiB | 593.28 KiB |
c6773e5 | 20.76 KiB | 435.25 KiB | 414.49 KiB |
236d8a8 | 21.58 KiB | 418.70 KiB | 397.12 KiB |
0001a09 | 20.76 KiB | 433.19 KiB | 412.43 KiB |
591a01b | 22.84 KiB | 401.67 KiB | 378.83 KiB |
645f63f | 21.58 KiB | 572.91 KiB | 551.33 KiB |
f0283e8 | 20.76 KiB | 393.36 KiB | 372.60 KiB |
1ce939e | 22.85 KiB | 412.98 KiB | 390.13 KiB |
60dd0f5 | 20.76 KiB | 393.36 KiB | 372.60 KiB |
brustolin
approved these changes
Apr 30, 2024
philipphofmann
added a commit
that referenced
this pull request
May 6, 2024
Ignore the thread sanitizer in the code where possible, which has the advantage of knowing a method is ignored when reading the code and not jumping to the ThreadSanitizer.sup file. Furthermore, use the ThreadSanitizer.sup file not only for tests but for the Run Xcode schemes.
dKasabwala
pushed a commit
to dKasabwala/sentry-cocoa
that referenced
this pull request
May 6, 2024
Ignore the thread sanitizer in the code where possible, which has the advantage of knowing a method is ignored when reading the code and not jumping to the ThreadSanitizer.sup file. Furthermore, use the ThreadSanitizer.sup file not only for tests but for the Run Xcode schemes.
threema-matteo
pushed a commit
to threema-ch/sentry-cocoa
that referenced
this pull request
May 21, 2024
Ignore the thread sanitizer in the code where possible, which has the advantage of knowing a method is ignored when reading the code and not jumping to the ThreadSanitizer.sup file. Furthermore, use the ThreadSanitizer.sup file not only for tests but for the Run Xcode schemes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore the thread sanitizer in the code where possible, which has the advantage of knowing a method is ignored when reading the code and not jumping to the ThreadSanitizer.sup file. Furthermore, use the ThreadSanitizer.sup file not only for tests but for the Run Xcode schemes.
This PR is based on #3922.
#skip-changelog