Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Format code with clang-format 18.1.5 #3935

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

philipphofmann
Copy link
Member

GH actions uses a new preinstalled clang-format version which now reformarts code on several PRs. Let's merge this so it doesn't need to do that on multiple PRs and they only need to update to main to fix this.

#skip-changelog

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.686%. Comparing base (8aec30e) to head (c3eded8).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3935       +/-   ##
=============================================
- Coverage   90.699%   90.686%   -0.013%     
=============================================
  Files          582       582               
  Lines        45523     45524        +1     
  Branches     16211     16223       +12     
=============================================
- Hits         41289     41284        -5     
- Misses        4164      4170        +6     
  Partials        70        70               
Files Coverage Δ
...yCrash/Recording/Monitors/SentryCrashMonitorType.c 0.000% <ø> (ø)
...entryCrash/Recording/Tools/SentryCrashSignalInfo.c 100.000% <ø> (ø)

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aec30e...c3eded8. Read the comment docs.

@brustolin
Copy link
Contributor

This duplicates a change in #3934

@philipphofmann philipphofmann merged commit ca507ec into main May 3, 2024
68 of 70 checks passed
@philipphofmann philipphofmann deleted the chore/clang-format branch May 3, 2024 12:15
@philipphofmann
Copy link
Member Author

This duplicates a change in #3934

I was unsure if this gets merged quickly. So I opened this PR.

Copy link

github-actions bot commented May 3, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1226.04 ms 1240.31 ms 14.27 ms
Size 21.58 KiB 616.76 KiB 595.18 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
7fb7afb 1230.12 ms 1251.04 ms 20.92 ms
97797b4 1199.27 ms 1213.54 ms 14.27 ms
5e78d2b 1245.24 ms 1270.28 ms 25.04 ms
2cf1b84 1221.10 ms 1230.34 ms 9.24 ms
eaf3840 1264.94 ms 1274.04 ms 9.10 ms
2b19b82 1237.45 ms 1256.60 ms 19.16 ms
bcb1c7d 1208.24 ms 1222.58 ms 14.34 ms
da5462e 1198.18 ms 1229.14 ms 30.96 ms
c6504da 1232.06 ms 1243.28 ms 11.22 ms
a71f5e2 1239.92 ms 1250.67 ms 10.76 ms

App size

Revision Plain With Sentry Diff
7fb7afb 20.76 KiB 419.70 KiB 398.94 KiB
97797b4 22.85 KiB 408.72 KiB 385.87 KiB
5e78d2b 22.85 KiB 411.17 KiB 388.32 KiB
2cf1b84 20.76 KiB 431.91 KiB 411.15 KiB
eaf3840 22.84 KiB 401.67 KiB 378.83 KiB
2b19b82 21.58 KiB 542.19 KiB 520.61 KiB
bcb1c7d 22.85 KiB 413.42 KiB 390.57 KiB
da5462e 22.85 KiB 412.98 KiB 390.13 KiB
c6504da 20.76 KiB 414.44 KiB 393.69 KiB
a71f5e2 21.58 KiB 424.34 KiB 402.76 KiB

dKasabwala pushed a commit to dKasabwala/sentry-cocoa that referenced this pull request May 6, 2024
threema-matteo pushed a commit to threema-ch/sentry-cocoa that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants