-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(profiling): set continuous profile id in each serialized transaction at keypath contexts.trace.data.profile_id #4030
Conversation
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
277f226 | 1241.65 ms | 1253.74 ms | 12.09 ms |
2cf1b84 | 1221.10 ms | 1230.34 ms | 9.24 ms |
db33900 | 1232.87 ms | 1250.35 ms | 17.47 ms |
f25febb | 1209.08 ms | 1225.90 ms | 16.81 ms |
add8416 | 1270.72 ms | 1300.38 ms | 29.66 ms |
861d361 | 1227.90 ms | 1231.45 ms | 3.55 ms |
b35ccd0 | 1233.92 ms | 1256.69 ms | 22.78 ms |
c9724f9 | 1199.38 ms | 1229.54 ms | 30.16 ms |
7512778 | 1200.78 ms | 1206.33 ms | 5.55 ms |
f2daa68 | 1238.40 ms | 1256.43 ms | 18.03 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
277f226 | 22.84 KiB | 401.67 KiB | 378.83 KiB |
2cf1b84 | 20.76 KiB | 431.91 KiB | 411.15 KiB |
db33900 | 21.58 KiB | 418.40 KiB | 396.82 KiB |
f25febb | 21.58 KiB | 414.92 KiB | 393.34 KiB |
add8416 | 21.58 KiB | 541.91 KiB | 520.33 KiB |
861d361 | 20.76 KiB | 435.65 KiB | 414.89 KiB |
b35ccd0 | 21.58 KiB | 573.13 KiB | 551.55 KiB |
c9724f9 | 20.76 KiB | 427.66 KiB | 406.90 KiB |
7512778 | 21.58 KiB | 539.87 KiB | 518.29 KiB |
f2daa68 | 21.58 KiB | 418.40 KiB | 396.82 KiB |
Previous results on branch: armcknight/feat/3555-continuous-profiling/5-implementation/13-add-profile-id-to-trace-contexts-data
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
9ed8b15 | 1220.94 ms | 1242.55 ms | 21.61 ms |
8954a99 | 1235.92 ms | 1258.39 ms | 22.47 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
9ed8b15 | 21.58 KiB | 654.53 KiB | 632.95 KiB |
8954a99 | 21.58 KiB | 655.96 KiB | 634.38 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found one major issue.
….trace.data.profile_id
…write a test for it that failed until making the fix
873f6b0
to
d9a59ee
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## armcknight/feat/3555-continuous-profiling/5-implementation/12-rework-continuous-profiling-options #4030 +/- ##
=======================================================================================================================================
- Coverage 91.151% 91.145% -0.006%
=======================================================================================================================================
Files 608 608
Lines 47691 47716 +25
Branches 17129 17128 -1
=======================================================================================================================================
+ Hits 43471 43491 +20
- Misses 4039 4045 +6
+ Partials 181 180 -1
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bfe78f6
into
armcknight/feat/3555-continuous-profiling/5-implementation/12-rework-continuous-profiling-options
Following along with #4009 , we also need the profile ID in each transaction (which just takes the id already recorded by the SentrySpan additions in that last PR when creating the transaction from the trace, which uses the span's logic as it's the superclass).
for #3555; #skip-changelog