fix: Deprecate SentryUser.segment

[philipphofmann]

Fixes GH-4090

[github-actions]

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

• Sources/Sentry/SentryNetworkTracker.m

[github-actions]

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

• Sources/Sentry/SentryNetworkTracker.m

[github-actions]

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1223.58 ms	1234.35 ms	10.77 ms
Size	21.58 KiB	675.79 KiB	654.21 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
742d4b6	1191.02 ms	1207.08 ms	16.06 ms
d0deebd	1235.17 ms	1255.54 ms	20.37 ms
3912b16	1230.54 ms	1249.65 ms	19.11 ms
53a8885	1241.02 ms	1270.66 ms	29.64 ms
3b782cc	1261.67 ms	1272.24 ms	10.57 ms
2384e6d	1225.90 ms	1245.47 ms	19.57 ms
a54df45	1232.62 ms	1247.30 ms	14.68 ms
8919322	1262.67 ms	1269.90 ms	7.22 ms
3297d6e	1219.02 ms	1243.25 ms	24.23 ms
0d32275	1229.62 ms	1246.51 ms	16.89 ms

App size

Revision	Plain	With Sentry	Diff
742d4b6	21.58 KiB	546.20 KiB	524.62 KiB
d0deebd	21.58 KiB	542.28 KiB	520.69 KiB
3912b16	21.58 KiB	625.82 KiB	604.24 KiB
53a8885	20.76 KiB	434.65 KiB	413.89 KiB
3b782cc	20.76 KiB	432.21 KiB	411.45 KiB
2384e6d	21.58 KiB	572.21 KiB	550.63 KiB
a54df45	20.76 KiB	434.88 KiB	414.12 KiB
8919322	22.84 KiB	403.18 KiB	380.34 KiB
3297d6e	21.58 KiB	418.45 KiB	396.86 KiB
0d32275	22.84 KiB	403.13 KiB	380.29 KiB

Previous results on branch: fix/deprecate-user-segment

Startup times

Revision	Plain	With Sentry	Diff
8bd7a11	1212.37 ms	1227.98 ms	15.61 ms

App size

Revision	Plain	With Sentry	Diff
8bd7a11	21.58 KiB	670.99 KiB	649.41 KiB

[armcknight]

Added this to #2946 (comment)

[github-actions]

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

• Sources/Sentry/SentryNetworkTracker.m

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.351%. Comparing base (1e803dc) to head (112855d).

Additional details and impacted files

@@              Coverage Diff              @@
##              main     #4092       +/-   ##
=============================================
+ Coverage   91.188%   91.351%   +0.162%     
=============================================
  Files          609       610        +1     
  Lines        47825     48308      +483     
  Branches         0     17451    +17451     
=============================================
+ Hits         43611     44130      +519     
+ Misses        4214      4086      -128     
- Partials         0        92       +92     

Files	Coverage Δ
Sources/Sentry/SentryClient.m	98.352% <100.000%> (+0.011%)	⬆️
Sources/Sentry/SentryNetworkTracker.m	96.805% <100.000%> (+0.353%)	⬆️
Sources/Sentry/SentryTraceContext.m	91.752% <100.000%> (+0.263%)	⬆️
Sources/Sentry/SentryUser.m	96.638% <100.000%> (+1.446%)	⬆️
...erformance/Network/SentryNetworkTrackerTests.swift	98.253% <ø> (ø)
Tests/SentryTests/Protocol/SentryUserTests.swift	100.000% <ø> (ø)
Tests/SentryTests/Protocol/TestData.swift	99.176% <ø> (-0.004%)	⬇️
Tests/SentryTests/SentryScopeSwiftTests.swift	99.139% <ø> (ø)
...entryTests/Transaction/SentryTraceStateTests.swift	100.000% <ø> (ø)

... and 96 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e803dc...112855d. Read the comment docs.