Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Session replay in buffer mode not working #4160

Merged
merged 4 commits into from
Jul 15, 2024
Merged

Conversation

brustolin
Copy link
Contributor

The frames during buffer mode were not being saved to disk.

#skip-changelog

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.308%. Comparing base (e773cad) to head (9e039ba).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4160       +/-   ##
=============================================
- Coverage   91.356%   91.308%   -0.048%     
=============================================
  Files          606       605        -1     
  Lines        48346     48255       -91     
  Branches     17447     17374       -73     
=============================================
- Hits         44167     44061      -106     
- Misses        4086      4100       +14     
- Partials        93        94        +1     
Files Coverage Δ
...tegrations/SessionReplay/SentrySessionReplay.swift 91.304% <100.000%> (ø)
...tions/SessionReplay/SentrySessionReplayTests.swift 97.633% <100.000%> (+0.117%) ⬆️

... and 21 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e773cad...9e039ba. Read the comment docs.

@brustolin brustolin merged commit 4c88d95 into main Jul 15, 2024
63 of 67 checks passed
@brustolin brustolin deleted the fix(SR)/buffer-mode branch July 15, 2024 14:25
Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1223.63 ms 1234.06 ms 10.44 ms
Size 21.58 KiB 681.82 KiB 660.24 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
60d6cec 1257.14 ms 1273.92 ms 16.78 ms
f0283e8 1253.36 ms 1263.12 ms 9.76 ms
ff09c7e 1240.94 ms 1262.66 ms 21.72 ms
ae9c51b 1244.85 ms 1264.33 ms 19.47 ms
f5623cd 1255.78 ms 1262.30 ms 6.52 ms
8aec30e 1235.73 ms 1255.87 ms 20.14 ms
c0ff306 1218.92 ms 1240.64 ms 21.72 ms
afd1a08 1207.78 ms 1223.44 ms 15.66 ms
9fa25c2 1211.88 ms 1228.36 ms 16.48 ms
2b19b82 1237.45 ms 1256.60 ms 19.16 ms

App size

Revision Plain With Sentry Diff
60d6cec 22.84 KiB 403.51 KiB 380.67 KiB
f0283e8 20.76 KiB 393.36 KiB 372.60 KiB
ff09c7e 20.76 KiB 427.76 KiB 407.00 KiB
ae9c51b 22.85 KiB 411.13 KiB 388.28 KiB
f5623cd 22.85 KiB 412.98 KiB 390.13 KiB
8aec30e 21.58 KiB 616.75 KiB 595.17 KiB
c0ff306 20.76 KiB 434.65 KiB 413.89 KiB
afd1a08 22.84 KiB 402.57 KiB 379.72 KiB
9fa25c2 22.85 KiB 407.44 KiB 384.59 KiB
2b19b82 21.58 KiB 542.19 KiB 520.61 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants