-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record dropped spans #4172
Record dropped spans #4172
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass. I will wait until the PR is open to review it again.
…ry-cocoa into feat/report-dropped-spans # Conflicts: # Sources/Sentry/SentryClient.m
…ry-cocoa into feat/report-dropped-spans
…ry-cocoa into feat/report-dropped-spans
…ry-cocoa into feat/report-dropped-spans
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4172 +/- ##
=============================================
+ Coverage 91.358% 91.411% +0.052%
=============================================
Files 606 606
Lines 48373 48658 +285
Branches 17468 17559 +91
=============================================
+ Hits 44193 44479 +286
+ Misses 4087 4086 -1
Partials 93 93
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. Looks good.
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
699d76f | 1233.96 ms | 1251.32 ms | 17.36 ms |
1ee3d54 | 1241.80 ms | 1250.67 ms | 8.87 ms |
7c5d161 | 1224.38 ms | 1249.66 ms | 25.28 ms |
69d8759 | 1229.88 ms | 1240.45 ms | 10.57 ms |
0ffe199 | 1209.51 ms | 1223.94 ms | 14.43 ms |
2e3ef92 | 1226.51 ms | 1241.21 ms | 14.70 ms |
d9cd5f1 | 1234.14 ms | 1257.69 ms | 23.54 ms |
e84bc3f | 1201.49 ms | 1232.82 ms | 31.33 ms |
9d28681 | 1230.08 ms | 1248.55 ms | 18.47 ms |
08e12bc | 1204.51 ms | 1215.98 ms | 11.47 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
699d76f | 21.58 KiB | 631.82 KiB | 610.24 KiB |
1ee3d54 | 21.58 KiB | 571.76 KiB | 550.18 KiB |
7c5d161 | 20.76 KiB | 414.44 KiB | 393.68 KiB |
69d8759 | 20.76 KiB | 393.05 KiB | 372.29 KiB |
0ffe199 | 20.76 KiB | 436.50 KiB | 415.74 KiB |
2e3ef92 | 21.58 KiB | 671.89 KiB | 650.31 KiB |
d9cd5f1 | 21.58 KiB | 544.73 KiB | 523.14 KiB |
e84bc3f | 20.76 KiB | 434.72 KiB | 413.96 KiB |
9d28681 | 20.76 KiB | 399.19 KiB | 378.43 KiB |
08e12bc | 21.58 KiB | 539.88 KiB | 518.30 KiB |
@brustolin Do you have an idea why the benchmarking task is failing? Building with fastlane seems to be the issue? |
It seems flaky. I don't think it's related to the PR |
@denrase What's keeping us from merging this? |
@brustolin Just the CI, thx for clarification 🙇 |
📜 Description
💡 Motivation and Context
Closes #4156
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps
Please check if these are all instances where we need to record dropped spans, as they are a bit different from Flutter/Java and i'm not too familiar with the Cocoa SDK. 🙇