Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Remove clearTestState in FileManagerTests #4220

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

philipphofmann
Copy link
Member

The tests also succeed without clearTestState, so we can remove the extra work.

#skip-changelog

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.412%. Comparing base (9f12001) to head (df3eb69).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4220       +/-   ##
=============================================
+ Coverage   91.406%   91.412%   +0.005%     
=============================================
  Files          611       611               
  Lines        49062     49061        -1     
  Branches     17726     17712       -14     
=============================================
+ Hits         44846     44848        +2     
+ Misses        4122      4120        -2     
+ Partials        94        93        -1     
Files Coverage Δ
...ts/SentryTests/Helper/SentryFileManagerTests.swift 99.299% <ø> (+0.173%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f12001...df3eb69. Read the comment docs.

@philipphofmann philipphofmann merged commit aa225e2 into main Aug 1, 2024
45 of 49 checks passed
@philipphofmann philipphofmann deleted the test/remove-clearteststate-filemanager branch August 1, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants