-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Accessing UI API on bg thread in enrichScope #4245
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix accessing UIDevice in enrich scope, which could be called on a background thread by caching the system version in the SentryUIDeviceWrapper.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4245 +/- ##
=============================================
- Coverage 91.495% 91.492% -0.003%
=============================================
Files 612 612
Lines 49455 49475 +20
Branches 17899 17903 +4
=============================================
+ Hits 45249 45266 +17
- Misses 4113 4117 +4
+ Partials 93 92 -1
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e8c8a05 | 1218.71 ms | 1234.50 ms | 15.79 ms |
1ce939e | 1222.22 ms | 1243.26 ms | 21.04 ms |
6d541bc | 1223.06 ms | 1242.38 ms | 19.32 ms |
ceb2092 | 1205.27 ms | 1221.44 ms | 16.17 ms |
2f8b3a8 | 1233.76 ms | 1260.24 ms | 26.48 ms |
db533ee | 1228.96 ms | 1248.23 ms | 19.28 ms |
728804f | 1235.26 ms | 1254.20 ms | 18.94 ms |
034be1c | 1222.67 ms | 1236.22 ms | 13.55 ms |
2affdbd | 1224.29 ms | 1248.06 ms | 23.77 ms |
6a6a5b2 | 1243.67 ms | 1252.51 ms | 8.84 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e8c8a05 | 21.58 KiB | 683.51 KiB | 661.92 KiB |
1ce939e | 22.85 KiB | 412.98 KiB | 390.13 KiB |
6d541bc | 21.58 KiB | 616.71 KiB | 595.13 KiB |
ceb2092 | 21.58 KiB | 670.39 KiB | 648.81 KiB |
2f8b3a8 | 20.76 KiB | 434.72 KiB | 413.96 KiB |
db533ee | 21.58 KiB | 547.02 KiB | 525.44 KiB |
728804f | 22.85 KiB | 411.76 KiB | 388.91 KiB |
034be1c | 20.76 KiB | 436.66 KiB | 415.90 KiB |
2affdbd | 22.85 KiB | 411.37 KiB | 388.52 KiB |
6a6a5b2 | 21.58 KiB | 698.12 KiB | 676.54 KiB |
brustolin
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Fix accessing UIDevice in enrich scope, which could be called on a background thread by caching the system version in the SentryUIDeviceWrapper.
💡 Motivation and Context
Came up in #3836 (comment) and while investigating flaky tests.
💚 How did you test it?
Unit tests.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps