Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a replay quality option for Objc #4267

Merged
merged 6 commits into from
Aug 12, 2024
Merged

Conversation

brustolin
Copy link
Contributor

📜 Description

Quality options was not exposed to Objc.

💚 How did you test it?

Sample

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link

github-actions bot commented Aug 9, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 8254aba

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.530%. Comparing base (d8cc6ae) to head (017f1e6).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4267       +/-   ##
=============================================
- Coverage   91.542%   91.530%   -0.012%     
=============================================
  Files          612       612               
  Lines        49470     49471        +1     
  Branches     17916     17897       -19     
=============================================
- Hits         45286     45281        -5     
- Misses        4091      4097        +6     
  Partials        93        93               
Files Coverage Δ
...tegrations/SessionReplay/SentryReplayOptions.swift 93.103% <ø> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8cc6ae...017f1e6. Read the comment docs.

Copy link

github-actions bot commented Aug 12, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1227.85 ms 1250.78 ms 22.92 ms
Size 21.58 KiB 700.24 KiB 678.66 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
6d00d1b 1235.04 ms 1251.21 ms 16.17 ms
f0283e8 1245.92 ms 1262.82 ms 16.90 ms
ce54c6a 1237.02 ms 1241.02 ms 4.00 ms
e8114e4 1243.22 ms 1253.16 ms 9.94 ms
60dd0f5 1265.16 ms 1275.04 ms 9.88 ms
aa27ac0 1214.02 ms 1227.42 ms 13.40 ms
2deb275 1228.20 ms 1245.02 ms 16.82 ms
c83ffd9 1235.15 ms 1256.92 ms 21.77 ms
85b619d 1252.51 ms 1275.33 ms 22.82 ms
0cc5400 1204.76 ms 1238.10 ms 33.35 ms

App size

Revision Plain With Sentry Diff
6d00d1b 21.58 KiB 694.62 KiB 673.04 KiB
f0283e8 20.76 KiB 393.37 KiB 372.61 KiB
ce54c6a 21.58 KiB 418.60 KiB 397.02 KiB
e8114e4 21.58 KiB 574.17 KiB 552.59 KiB
60dd0f5 20.76 KiB 393.37 KiB 372.61 KiB
aa27ac0 20.76 KiB 432.21 KiB 411.45 KiB
2deb275 21.58 KiB 681.72 KiB 660.14 KiB
c83ffd9 21.58 KiB 573.16 KiB 551.57 KiB
85b619d 20.76 KiB 426.11 KiB 405.35 KiB
0cc5400 21.58 KiB 615.62 KiB 594.04 KiB

Previous results on branch: fix/expose-quality-objc

Startup times

Revision Plain With Sentry Diff
02bbbd2 1224.71 ms 1242.94 ms 18.22 ms

App size

Revision Plain With Sentry Diff
02bbbd2 21.58 KiB 699.24 KiB 677.66 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm surprised that somebody complained about this 😄

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Philipp Hofmann <[email protected]>
@brustolin brustolin merged commit 594c2e6 into main Aug 12, 2024
45 of 46 checks passed
@brustolin brustolin deleted the fix/expose-quality-objc branch August 12, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants