Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Session replay not redacting buttons and other non UILabel texts #4277

Merged
merged 5 commits into from
Aug 13, 2024

Conversation

brustolin
Copy link
Contributor

📜 Description

Subclasses of classes that should be redacted were not.

💚 How did you test it?

Unit tests

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.583%. Comparing base (594c2e6) to head (ead7c5d).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4277       +/-   ##
=============================================
+ Coverage   91.539%   91.583%   +0.044%     
=============================================
  Files          612       616        +4     
  Lines        49499     49926      +427     
  Branches     17922     18056      +134     
=============================================
+ Hits         45311     45724      +413     
- Misses        4096      4110       +14     
  Partials        92        92               
Files Coverage Δ
Sources/Swift/Tools/UIRedactBuilder.swift 99.099% <100.000%> (+0.042%) ⬆️
Tests/SentryTests/UIRedactBuilderTests.swift 100.000% <100.000%> (ø)

... and 15 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 594c2e6...ead7c5d. Read the comment docs.

Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1209.08 ms 1226.35 ms 17.27 ms
Size 21.58 KiB 704.99 KiB 683.40 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
340fb46 1236.45 ms 1244.38 ms 7.93 ms
9f12001 1235.61 ms 1246.80 ms 11.18 ms
7512778 1200.78 ms 1206.33 ms 5.55 ms
97de6c8 1226.78 ms 1240.98 ms 14.20 ms
feba2be 1246.67 ms 1254.64 ms 7.97 ms
643853e 1225.75 ms 1247.00 ms 21.25 ms
2deb275 1224.04 ms 1239.37 ms 15.33 ms
b2c9166 1246.86 ms 1255.28 ms 8.42 ms
6e31b7c 1230.80 ms 1246.29 ms 15.49 ms
25bcc50 1209.53 ms 1224.86 ms 15.33 ms

App size

Revision Plain With Sentry Diff
340fb46 21.58 KiB 418.78 KiB 397.20 KiB
9f12001 21.58 KiB 694.47 KiB 672.89 KiB
7512778 21.58 KiB 539.87 KiB 518.29 KiB
97de6c8 21.58 KiB 613.99 KiB 592.41 KiB
feba2be 20.76 KiB 414.45 KiB 393.69 KiB
643853e 21.58 KiB 655.73 KiB 634.15 KiB
2deb275 21.58 KiB 681.72 KiB 660.14 KiB
b2c9166 21.58 KiB 630.26 KiB 608.68 KiB
6e31b7c 21.58 KiB 614.65 KiB 593.07 KiB
25bcc50 20.76 KiB 427.22 KiB 406.46 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brustolin brustolin merged commit 02671d8 into main Aug 13, 2024
64 of 65 checks passed
@brustolin brustolin deleted the fix/sr-redact branch August 13, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants