Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Proper redact SR during animation #4289

Merged
merged 4 commits into from
Aug 26, 2024
Merged

Fix: Proper redact SR during animation #4289

merged 4 commits into from
Aug 26, 2024

Conversation

brustolin
Copy link
Contributor

📜 Description

Before:
745509807 087186

After:
745506683 275322

💚 How did you test it?

Samples

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.680%. Comparing base (dde49e2) to head (a457924).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #4289   +/-   ##
=========================================
  Coverage   91.680%   91.680%           
=========================================
  Files          617       617           
  Lines        50205     50205           
  Branches     18110     18130   +20     
=========================================
  Hits         46028     46028           
- Misses        4084      4085    +1     
+ Partials        93        92    -1     
Files Coverage Δ
Sources/Swift/Tools/UIRedactBuilder.swift 99.099% <100.000%> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dde49e2...a457924. Read the comment docs.

Copy link

github-actions bot commented Aug 16, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1217.47 ms 1235.76 ms 18.29 ms
Size 21.58 KiB 706.98 KiB 685.39 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
6129be5 1215.65 ms 1247.18 ms 31.54 ms
699d76f 1221.06 ms 1235.00 ms 13.94 ms
0a12181 1231.37 ms 1248.13 ms 16.75 ms
2ca242e 1228.19 ms 1244.78 ms 16.59 ms
7cd187e 1229.02 ms 1233.06 ms 4.04 ms
7bbb7c3 1232.40 ms 1249.78 ms 17.38 ms
6604dbb 1248.35 ms 1256.14 ms 7.79 ms
1ee3d54 1241.80 ms 1250.67 ms 8.87 ms
b3fd863 1217.81 ms 1231.31 ms 13.50 ms
af1f4dd 1232.39 ms 1255.88 ms 23.49 ms

App size

Revision Plain With Sentry Diff
6129be5 21.58 KiB 418.00 KiB 396.42 KiB
699d76f 21.58 KiB 631.83 KiB 610.25 KiB
0a12181 21.58 KiB 419.20 KiB 397.61 KiB
2ca242e 21.58 KiB 643.27 KiB 621.69 KiB
7cd187e 20.76 KiB 401.65 KiB 380.89 KiB
7bbb7c3 21.58 KiB 418.78 KiB 397.20 KiB
6604dbb 22.84 KiB 402.56 KiB 379.72 KiB
1ee3d54 21.58 KiB 571.76 KiB 550.18 KiB
b3fd863 21.58 KiB 706.85 KiB 685.27 KiB
af1f4dd 22.85 KiB 414.71 KiB 391.86 KiB

Previous results on branch: fix/sr-redact

Startup times

Revision Plain With Sentry Diff
f34f2d3 1218.94 ms 1233.63 ms 14.69 ms
9844f6e 1209.08 ms 1226.35 ms 17.27 ms

App size

Revision Plain With Sentry Diff
f34f2d3 21.58 KiB 707.38 KiB 685.80 KiB
9844f6e 21.58 KiB 704.99 KiB 683.40 KiB

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tests though

@brustolin
Copy link
Contributor Author

Missing tests though

I have validated this with the sample as shown in the screenshots. I know this doesn't prevent regression, but this behavior is strongly dependent on the animation API, which is not easy to test with unit tests.

@brustolin brustolin merged commit 077e940 into main Aug 26, 2024
65 checks passed
@brustolin brustolin deleted the fix/sr-redact branch August 26, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants