-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Proper redact SR during animation #4289
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4289 +/- ##
=========================================
Coverage 91.680% 91.680%
=========================================
Files 617 617
Lines 50205 50205
Branches 18110 18130 +20
=========================================
Hits 46028 46028
- Misses 4084 4085 +1
+ Partials 93 92 -1
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6129be5 | 1215.65 ms | 1247.18 ms | 31.54 ms |
699d76f | 1221.06 ms | 1235.00 ms | 13.94 ms |
0a12181 | 1231.37 ms | 1248.13 ms | 16.75 ms |
2ca242e | 1228.19 ms | 1244.78 ms | 16.59 ms |
7cd187e | 1229.02 ms | 1233.06 ms | 4.04 ms |
7bbb7c3 | 1232.40 ms | 1249.78 ms | 17.38 ms |
6604dbb | 1248.35 ms | 1256.14 ms | 7.79 ms |
1ee3d54 | 1241.80 ms | 1250.67 ms | 8.87 ms |
b3fd863 | 1217.81 ms | 1231.31 ms | 13.50 ms |
af1f4dd | 1232.39 ms | 1255.88 ms | 23.49 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6129be5 | 21.58 KiB | 418.00 KiB | 396.42 KiB |
699d76f | 21.58 KiB | 631.83 KiB | 610.25 KiB |
0a12181 | 21.58 KiB | 419.20 KiB | 397.61 KiB |
2ca242e | 21.58 KiB | 643.27 KiB | 621.69 KiB |
7cd187e | 20.76 KiB | 401.65 KiB | 380.89 KiB |
7bbb7c3 | 21.58 KiB | 418.78 KiB | 397.20 KiB |
6604dbb | 22.84 KiB | 402.56 KiB | 379.72 KiB |
1ee3d54 | 21.58 KiB | 571.76 KiB | 550.18 KiB |
b3fd863 | 21.58 KiB | 706.85 KiB | 685.27 KiB |
af1f4dd | 22.85 KiB | 414.71 KiB | 391.86 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing tests though
I have validated this with the sample as shown in the screenshots. I know this doesn't prevent regression, but this behavior is strongly dependent on the animation API, which is not easy to test with unit tests. |
📜 Description
Before:
After:
💚 How did you test it?
Samples
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps