-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add custom redact modifier for SwiftUI #4362
Conversation
…sentry/sentry-cocoa into fix/redact-under-translucent
…y-cocoa into fix/redact-logic
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4362 +/- ##
=============================================
- Coverage 91.535% 91.451% -0.085%
=============================================
Files 628 631 +3
Lines 50706 50757 +51
Branches 18396 18393 -3
=============================================
+ Hits 46414 46418 +4
- Misses 4199 4246 +47
Partials 93 93
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments, nothing blocking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ntry-cocoa into feat/swiftui-redact
📜 Description
Added a SwiftUI modifier that allows the dev to choose with part of the View they want redacted during replay.
💡 Motivation and Context
closes #4333
💚 How did you test it?
Sample
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps