Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Masking text with transparent text color #4499

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

brustolin
Copy link
Contributor

📜 Description

Labels with transparent text color get a transparent rectangle masking over. Removed the alpha component of the text color to use in the masking.

💚 How did you test it?

Unit tests

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.444%. Comparing base (ed470cf) to head (6ffd94a).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4499       +/-   ##
=============================================
+ Coverage   91.439%   91.444%   +0.004%     
=============================================
  Files          616       616               
  Lines        68794     68808       +14     
  Branches     24677     24686        +9     
=============================================
+ Hits         62905     62921       +16     
+ Misses        5796      5794        -2     
  Partials        93        93               
Files with missing lines Coverage Δ
Sources/Swift/Tools/UIRedactBuilder.swift 92.857% <100.000%> (ø)
Tests/SentryTests/UIRedactBuilderTests.swift 100.000% <100.000%> (ø)

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed470cf...6ffd94a. Read the comment docs.

Copy link

github-actions bot commented Nov 4, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1229.92 ms 1250.65 ms 20.73 ms
Size 21.90 KiB 725.96 KiB 704.06 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a0601b7 1221.23 ms 1231.71 ms 10.48 ms
704d854 1219.82 ms 1243.69 ms 23.87 ms
455619d 1253.08 ms 1265.06 ms 11.98 ms
b2e7962 1234.70 ms 1241.98 ms 7.28 ms
5230990 1222.86 ms 1243.59 ms 20.73 ms
33b2f51 1251.24 ms 1259.18 ms 7.94 ms
df2986b 1227.45 ms 1244.35 ms 16.90 ms
6e342ac 1216.02 ms 1232.88 ms 16.86 ms
c45c91c 1229.49 ms 1242.94 ms 13.45 ms
25a5e8b 1249.18 ms 1268.42 ms 19.24 ms

App size

Revision Plain With Sentry Diff
a0601b7 21.58 KiB 682.12 KiB 660.54 KiB
704d854 21.58 KiB 615.98 KiB 594.40 KiB
455619d 20.76 KiB 432.87 KiB 412.11 KiB
b2e7962 21.58 KiB 670.39 KiB 648.81 KiB
5230990 21.58 KiB 682.39 KiB 660.81 KiB
33b2f51 20.76 KiB 432.17 KiB 411.41 KiB
df2986b 22.85 KiB 406.89 KiB 384.04 KiB
6e342ac 20.76 KiB 436.66 KiB 415.90 KiB
c45c91c 21.58 KiB 714.30 KiB 692.72 KiB
25a5e8b 20.76 KiB 436.33 KiB 415.57 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brustolin brustolin merged commit 1223af7 into main Nov 5, 2024
64 checks passed
@brustolin brustolin deleted the fix/redact-of-transparent-text branch November 5, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants