Skip to content

Commit

Permalink
revert ci changes
Browse files Browse the repository at this point in the history
  • Loading branch information
denrase committed May 16, 2023
1 parent b3c1faf commit 00385e1
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 15 deletions.
13 changes: 2 additions & 11 deletions .github/workflows/analyze.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,20 +44,11 @@ jobs:

- run: dart fix --apply

- name: swiftlint --fix
uses: norio-nomura/action-swiftlint@9f4dcd7fd46b4e75d7935cf2f4df406d5cae3684 # [email protected]
if: ${{ inputs.package == 'flutter' }}
with:
args: --strict --fix

# actions/checkout fetches only a single commit in a detached HEAD state. Therefore
# we need to pass the current branch, otherwise we can't commit the changes.
# GITHUB_HEAD_REF is the name of the head branch. GitHub Actions only sets this for PRs.
- name: commit formatted code
env:
BRANCH_NAME: ${{ github.head_ref || github.ref_name }}
run: echo $BRANCH_NAME # ../scripts/commit-formatted-code.sh $BRANCH_NAME
if: $BRANCH_NAME != null
- run: ../scripts/commit-formatted-code.sh $GITHUB_HEAD_REF
if: env.GITHUB_HEAD_REF != null

- name: dart analyze
uses: invertase/github-action-dart-analyzer@cdd8652b05bf7ed08ffce30f425436780f869f13 # pin@v1
Expand Down
12 changes: 12 additions & 0 deletions .github/workflows/flutter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,18 @@ jobs:
# https://github.com/CocoaPods/CocoaPods/issues/5275#issuecomment-315461879
- run: pod lib lint ios/sentry_flutter.podspec --configuration=Debug --skip-import-validation --allow-warnings

swift-lint:
runs-on: ubuntu-latest
timeout-minutes: 20
defaults:
run:
working-directory: ./flutter
steps:
- uses: actions/checkout@v3
- uses: norio-nomura/action-swiftlint@9f4dcd7fd46b4e75d7935cf2f4df406d5cae3684 # [email protected]
with:
args: --strict

ktlint:
runs-on: ubuntu-latest
timeout-minutes: 20
Expand Down
2 changes: 0 additions & 2 deletions flutter/ios/Classes/SentryFlutterPluginApple.swift
Original file line number Diff line number Diff line change
Expand Up @@ -576,8 +576,6 @@ public class SentryFlutterPluginApple: NSObject, FlutterPlugin {
result("")
}



private func addBreadcrumb(breadcrumb: [String: Any?]?, result: @escaping FlutterResult) {
if let breadcrumb = breadcrumb {
let breadcrumbInstance = PrivateSentrySDKOnly.breadcrumb(with: breadcrumb)
Expand Down
3 changes: 1 addition & 2 deletions flutter/lib/src/sentry_flutter_options.dart
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ class SentryFlutterOptions extends SentryOptions {
///
/// Disabling this feature affects the [enableAutoSessionTracking]
/// feature, as this is required to mark Sessions as Crashed.
bool enableNativeCrashHandling =
true;
bool enableNativeCrashHandling = true;

Duration _autoSessionTrackingInterval = Duration(milliseconds: 30000);

Expand Down

0 comments on commit 00385e1

Please sign in to comment.